Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Port a couple more RPC APIs to the new auto args #2325

Merged
merged 20 commits into from
Oct 4, 2016
Merged

Port a couple more RPC APIs to the new auto args #2325

merged 20 commits into from
Oct 4, 2016

Conversation

rphmeier
Copy link
Contributor

No description provided.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Sep 26, 2016
@gavofyork gavofyork added A8-looksgood 🦄 Pull request is reviewed well. A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A0-pleasereview 🤓 Pull request needs code review. A8-looksgood 🦄 Pull request is reviewed well. labels Sep 26, 2016
@rphmeier rphmeier added A8-looksgood 🦄 Pull request is reviewed well. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Sep 27, 2016
@gavofyork
Copy link
Contributor

why isn't travis being triggered?

@rphmeier rphmeier closed this Sep 27, 2016
@rphmeier rphmeier reopened this Sep 27, 2016
@rphmeier
Copy link
Contributor Author

triggered now.

@gavofyork
Copy link
Contributor

oh dear... there's an async RPC now...

@gavofyork gavofyork added A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. and removed A8-looksgood 🦄 Pull request is reviewed well. labels Sep 27, 2016
@rphmeier
Copy link
Contributor Author

rphmeier commented Sep 27, 2016 •
edited
Loading

auto args needs to support async (and soon duplex) functions anyway, i'll get it into this PR but can't say exactly when. Will take a look in the next few days.

@rphmeier rphmeier added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A7-looksgoodcantmerge 🙄 Pull request is reviewed well, but cannot be merged due to conflicts. labels Sep 27, 2016
@coveralls
Copy link

Coverage Status

Changes Unknown when pulling d773ba5 on rpc-separation into * on master*.

@gavofyork gavofyork added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Sep 27, 2016
@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 30, 2016
@rphmeier
Copy link
Contributor Author

auto_args now supports async.

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 991f006 on rpc-separation into * on master*.

@rphmeier
Copy link
Contributor Author

rphmeier commented Oct 2, 2016

Looks like this is broken under Rust 1.10.0, due to some improvements to the macro system. Unfortunately, our build is also broken on Windows with 1.12.0. I'll see if I can fiddle with the macros to be backwards compatible.

@rphmeier rphmeier added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 3, 2016
@rphmeier
Copy link
Contributor Author

rphmeier commented Oct 3, 2016

on ice until #2423 is resolvable. Turns out 1.12.0 actually made token trees useful and my changes can't be trivially backported.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. and removed A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. labels Oct 4, 2016
@rphmeier
Copy link
Contributor Author

rphmeier commented Oct 4, 2016

(wait for the builds on a4c9cc6 before merging )

@coveralls
Copy link

Coverage Status

Coverage decreased (-0.0002%) to 86.476% when pulling 0be6772 on rpc-separation into e1d3b3f on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 4, 2016
@arkpar arkpar merged commit b7814fa into master Oct 4, 2016
@arkpar arkpar deleted the rpc-separation branch October 4, 2016 17:05
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@rphmeier @gavofyork @coveralls @arkpar