This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Merge IPC codegen attributes into one #2460
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
added
A0-pleasereview 🤓
rphmeier
reviewed
Oct 4, 2016
| @@ -49,7 +49,7 @@ pub fn expand_ipc_implementation( | |||
| let item = match *annotatable { | |||
| Annotatable::Item(ref item) => item, | |||
| _ => { | |||
| cx.span_err(meta_item.span, "`#[derive(Ipc)]` may only be applied to struct implementations"); | |||
| cx.span_err(meta_item.span, "`#[ipc]` may only be applied to struct implementations"); | |||
There was a problem hiding this comment.
this error doesn't match up with the other one in this file.
rphmeier
reviewed
Oct 4, 2016
| @@ -832,7 +832,7 @@ fn implement_interface( | |||
| _ => { | |||
| cx.span_err( | |||
| item.span, | |||
| "`#[derive(Ipc)]` may only be applied to implementations and traits"); | |||
| "`#[ipc]` may only be applied to implementations and traits"); | |||
There was a problem hiding this comment.
I think this one is more recent/correct
rphmeier
added
A8-looksgood 🦄
rphmeier
reviewed
Oct 5, 2016
| @@ -29,5 +29,6 @@ ethcore-ipc-nano = { path = "../ipc/nano" } | |||
| parking_lot = "0.2.6" | |||
|
|
|||
| [features] | |||
| default = [] | |||
| default = ["ipc"] | |||
There was a problem hiding this comment.
Probably best not to have this as default; it'll already get triggered by parity's default features and IPC probably isn't wanted when testing as it means more work for rustc
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.