Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Fixed tx queue limit for local transactions #2616

Merged
merged 3 commits into from
Oct 14, 2016
Merged

Fixed tx queue limit for local transactions #2616

merged 3 commits into from
Oct 14, 2016

Conversation

arkpar
Copy link
Collaborator

@arkpar arkpar commented Oct 13, 2016

No description provided.

@arkpar arkpar added A0-pleasereview 🤓 Pull request needs code review. B0-patch M4-core ⛓ Core client code / Rust. labels Oct 13, 2016
@tomusdrw tomusdrw added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 14, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.03%) to 86.472% when pulling 1828921 on tx-queue-fix into 4581469 on master.

// Set total tx queue gas limit to be 2x the block gas limit.
queue.set_total_gas_limit(gas_limit << 1);
// Set total tx queue gas limit to be 20x the block gas limit.
queue.set_total_gas_limit(gas_limit * 20.into());
Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased this since lots of transactions set their gas too high (10x of what is required)

@coveralls
Copy link

Coverage Status

Coverage increased (+0.002%) to 86.503% when pulling d7cfef2 on tx-queue-fix into 4581469 on master.

@arkpar arkpar merged commit f9440f2 into master Oct 14, 2016
arkpar added a commit that referenced this pull request Oct 14, 2016
* Fixed tx queue limit for local tx

* Fixing test

* Increas gas limit to 20x
arkpar added a commit that referenced this pull request Oct 14, 2016
* v1.3.8

* mitigate refcell conflict in state diffing (#2601)

* mitigate refcell conflict in state diffing

Also uses RefCell::get_mut in a few places.

* Add test case

* Fixed stalled sync

* Fixed tx queue limit for local transactions (#2616)

* Fixed tx queue limit for local tx

* Fixing test

* Increas gas limit to 20x

* Additional logs when transactions is removed from queue (#2617)

* Database performance tweaks (#2619)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants