This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Allow tags for Accounts, Addresses and Contracts #2712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like this contributor signed our Contributor License Agreement. 👍 Many thanks, Ethcore CLA Bot |
jacogr
reviewed
Oct 19, 2016
| @@ -131,6 +132,16 @@ module.exports = { | |||
| ] | |||
| }), | |||
| new HappyPack({ | |||
| id: 'less', | |||
There was a problem hiding this comment.
So it's not used by any file, but it was there previously, so not sure...
Should we get completely rid of LESS ? (ie. in Webpack and package.json)
There was a problem hiding this comment.
If we are not using it, yes, best approach.
jacogr
added
A8-looksgood 🦄
|
Changes Unknown when pulling 05cdecc on ng-ui-tags into * on master*. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
[Copy of PR #2697]
Closes #2643
This PR adds tagging capabilities to Accounts, Addresses and Contracts. Multiple can be added per item, and these can be searched. They can also be sorted by name or by tag.
Currently, the search accepts multiple tokens, that are joined with OR ; eg. if item 1 has tag foo and item 2 has tag bar, as search for the two tokens foo and bar will display item 1 and 2.
This can be changed easily to an AND behavior.
See it in action here: https://youtu.be/3UA-QI0G_UQ