Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Incrementally calculate verification queue heap size #2749

Merged
merged 3 commits into from
Oct 20, 2016
Merged

Incrementally calculate verification queue heap size #2749

merged 3 commits into from
Oct 20, 2016

Conversation

rphmeier
Copy link
Contributor

cc @arkpar

The heap_size_of_children calls in queue_info were doing a lot of redundant calculations while holding locks on the sub-queues. This PR does the calculation incrementally during each point in an item's lifespan, from insertion to removal and does no redundant work.

@rphmeier rphmeier added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Oct 20, 2016
@coveralls
Copy link

Coverage Status

Coverage decreased (-0.002%) to 86.261% when pulling 6e72c77 on incremental-queue-size into d2e4baf on master.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Oct 20, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.02%) to 86.249% when pulling 6f906ac on incremental-queue-size into 906dcd7 on master.

@arkpar arkpar merged commit 7359af8 into master Oct 20, 2016
arkpar pushed a commit that referenced this pull request Oct 20, 2016
@rphmeier @arkpar
Incrementally calculate verification queue heap size (#2749)
bb3da53 
* incrementally calculate queue heap size

* query the correct queue sizes
arkpar added a commit that referenced this pull request Oct 20, 2016
@arkpar
Backports for beta (#2764)
b3097c8 
* v1.3.9

* Block import optimization (#2748)

* Block import optimization

* whitespace

[ci:none]

* Don't add empty accounts to bloom (#2753)

* Incrementally calculate verification queue heap size (#2749)

* incrementally calculate queue heap size

* query the correct queue sizes
@gavofyork gavofyork deleted the incremental-queue-size branch November 3, 2016 11:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@rphmeier @coveralls @arkpar