new InputAddressSelect component

[derhuerst]

This PR gives InputAddressSelect an overhaul. It fixes #3008. #3006 gets fixed indirectly because by default the input is empty.

The new idea behind the rewrite was to make it as comfortable as possible to fill in an address. There's completion by name & address and no toggle. You can enter an address both with and without a leading address.

What #3057 does for InputAddress, is done by this PR for InputAddressSelect.

Edit: I haven't checked for compatibility in all the places where InputAddressSelect is used. Will do that tomorrow.

[derhuerst]

Let me know what you think about the default IdentityIcon being gray. (It will show the pattern once the input begins with 0x.)

[jacogr]

Marked in-progress until you are comfortable and it actually has been checked. The risk is high, do a proper testing job on this one first before PR-ing.

[jacogr]

As per @ngotchac PR - unless the address is valid, no IdentityIcon at all. It only gets displayed when the address is valid.

[chevdor]

Tested in the current version. I like the direction this is taking.

I miss the ability to click on the control to pull the list of known addresses and select from there.
While no absolute must, the previous resolution from a given address to a known name was nice and is (so far) missing in what I tested.

The toggle edit/search disappeared, which IMHO is a GREAT thing! Well done @derhuerst.
Warning, in the version I tested, the validation was gone: 0x12234 was not seen as invalid address, 0xasdf either.

I am currently working on an address component (not react), here are some screenshots if that can help:

[chevdor]

@jacogr in the current version, this is not the case:

[derhuerst]

Warning, in the version I tested, the validation was gone: 0x12234 was not seen as invalid address, 0xasdf either.

Will address.

[gavofyork]

See also #3088 and #3091.

[gavofyork]

address both with and without a leading address

???

[derhuerst]

@gavofyork

address both with and without a leading address

???

typo. You can enter an address both with and without a leading 0x.

[chevdor]

See #3093

[jacogr]

Comments -

• Step in the right direction, it shows promise
• UI is now inconsistent, this field doesn't not have the placeholders or labels in the correct places
• looking at 2 icon fields side-by-side - they don't match up

• Own accounts always first, then addresses, then contracts (and sorted, when dealing with text, that is what people expect)

• Invalid addresses still show IdentityIcons

• I'm assuming your comment from yesterday is not valid anymore? (re the testing)

[ngotchac]

I like better the icon outside of the input as @derhuerst did. I think it should be like that for every input with an icon.

[jacogr]

I don't have a preference either way - but if it gets moved, it gets moved everywhere - needs to be consistent, cannot do it half-way. (nd do bear the copy in mind as well, we know there are some fields that needs to move to address that is copyable, so if outside - alignment and ll elements needs to be taken into account)

With the above, I think the best first-round option is to keep it where it was (no other impacts) and then look in another issue how to move everything out.)

[jacogr]

Updated. @derhuerst was 100% correct in his assessment - instead of re-inventing the wheel, rather use the AddressSelect component as developed by @ngotchac and adapt it to also take care of "copy text" inputs. Basically the code between the 2 components has to be 90% the same - rather don't repeat the same code again. Also solves the styling issues, since already taken care of in the original AddressSelect component for consistency.

In short: Simplified greatly, re-used what is there. Video of it in action -

https://youtu.be/wOW18OtXTzo

Excuse the - (a) slugishness, Parity is syncing and (b) crash of Parity (stack-trace in #retreat)

[jacogr]

Updated. Closes https://github.com/ethcore/parity/issues/3073 - contracts in the address search.

https://youtu.be/_ooiw0FysVk

[coveralls]

Changes Unknown when pulling c8a7ebf on new-input-address-select into * on master*.

[GitCop]

There were the following issues with your Pull Request

• Commit: ec2d3ec
  • Your commit message body contains a line that is longer than 72 characters

Guidelines are available at https://github.com/ethcore/parity

---

This message was auto-generated by https://gitcop.com

[GitCop]

There were the following issues with your Pull Request

• Commit: ec2d3ec
  • Your commit message body contains a line that is longer than 72 characters

Guidelines are available at https://github.com/ethcore/parity

---

This message was auto-generated by https://gitcop.com

[chevdor]

Should be used for #3134