This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Make the Engine hold AccountProvider #3499
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
keorn
added
A0-pleasereview 🤓
added 2 commits
November 17, 2016 19:04
tomusdrw
reviewed
Nov 18, 2016
| work_poster: Option<WorkPoster>, | ||
| gas_pricer: Mutex<GasPricer>, | ||
| } | ||
|
|
||
| impl Miner { | ||
| /// Creates new instance of miner. | ||
| fn new_raw(options: MinerOptions, gas_pricer: GasPricer, spec: &Spec, accounts: Option<Arc<AccountProvider>>) -> Miner { | ||
| fn new_raw(options: MinerOptions, gas_pricer: GasPricer, spec: &Spec) -> Miner { |
There was a problem hiding this comment.
The change is conflicting with #3491 - I'm actually using AccountProvider in miner to identify local transactions :/
tomusdrw
added
A5-grumble 🔥
|
I see, will just add it to the |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
Minerwas holdingAccountProviderand passing it on sealing generation, when it was used only byBasicAuthorityandAuthorityRound. Now it will also be possible to use it in other situations when signing is necessary.Not sure if the registering part is nice:
Mutex<Option<Arc<AccountProvider>>>.