This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Use accountsInfo instead of eth_accounts for first check #3618
Merged
Merged
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
// Copyright 2015, 2016 Ethcore (UK) Ltd. | ||
// This file is part of Parity. | ||
|
||
// Parity is free software: you can redistribute it and/or modify | ||
// it under the terms of the GNU General Public License as published by | ||
// the Free Software Foundation, either version 3 of the License, or | ||
// (at your option) any later version. | ||
|
||
// Parity is distributed in the hope that it will be useful, | ||
// but WITHOUT ANY WARRANTY; without even the implied warranty of | ||
// MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the | ||
// GNU General Public License for more details. | ||
|
||
// You should have received a copy of the GNU General Public License | ||
// along with Parity. If not, see <http://www.gnu.org/licenses/>. | ||
|
||
import { action, observable } from 'mobx'; | ||
|
||
const showFirstRun = window.localStorage.getItem('showFirstRun') !== '0'; | ||
|
||
export default class Store { | ||
@observable firstrunVisible = showFirstRun; | ||
|
||
constructor (api) { | ||
this._api = api; | ||
|
||
this._checkAccounts(); | ||
} | ||
|
||
@action closeFirstrun = () => { | ||
this.toggleFirstrun(false); | ||
} | ||
|
||
@action toggleFirstrun = (visible = false) => { | ||
this.firstrunVisible = visible; | ||
window.localStorage.setItem('showFirstRun', visible ? '1' : '0'); | ||
} | ||
|
||
_checkAccounts () { | ||
this._api.parity | ||
.accountsInfo() | ||
.then((info) => { | ||
const accounts = Object.keys(info).filter((address) => info[address].uuid); | ||
|
||
this.toggleFirstrun(this.firstrunVisible || !accounts || !accounts.length); | ||
}) | ||
.catch((error) => { | ||
console.error('checkAccounts', error); | ||
}); | ||
} | ||
} |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do we really need to make this call each time the app if started ? I guess if
showFirstRun
is set to0
in LS, we shouldn't need to display this modal even if I deleted all my accounts.Plus, if
this.firstrunVisisble
istrue
, this call is useless.Lastly, can't we tweak the window to skip the account creation if the user already have some created accounts ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We actually have the above actually logged as an enhancement, https://github.com/ethcore/parity/issues/3583. (Won't get in with 1.5 though)
Didn't try to re-invent the world, just tried to take what we have and change the call - already did more than needed with the move to a store to clean up a little bit. (With the
eth_account
changes it will show up each and every time, so this is needed before that change lands)There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay fair.