This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 1.7k
Status page updates #3774
Merged
Merged
Status page updates #3774
Changes from all commits
Commits
Show all changes
13 commits
Select commit
Hold shift + click to select a range
623384a
Allow Page to create optional Actionbar
jacogr c8f8d93
Typo
jacogr 11ca5c0
Display last block.timestamp
jacogr 72fc500
Remove unnneeded console.log
jacogr 4186362
Re-do git mv
jacogr 734f056
Merge branch 'master' into jg-status-updates
jacogr e2ffbe6
Merge branch 'master' into jg-status-updates
jacogr b13af51
git mv
jacogr c706879
Merge branch 'master' into jg-status-updates
jacogr 0fd9c14
Force build changes
jacogr 254a1c6
Resolving case sensitivity issues
ngotchac bd80830
Merge branch 'master' into jg-status-updates
jacogr 5efd29a
Swapped to margin at bottom
jacogr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -18,7 +18,7 @@ | |
.layout { | ||
padding: 0.25em 0.25em 1em 0.25em; | ||
|
||
> * { | ||
&>div { | ||
margin-bottom: 0.75em; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -16,21 +16,38 @@ | |
|
||
import React, { Component, PropTypes } from 'react'; | ||
|
||
import Actionbar from '../Actionbar'; | ||
import { nodeOrStringProptype } from '~/util/proptypes'; | ||
|
||
import styles from './page.css'; | ||
|
||
export default class Page extends Component { | ||
static propTypes = { | ||
buttons: PropTypes.array, | ||
className: PropTypes.string, | ||
children: PropTypes.node | ||
children: PropTypes.node, | ||
title: nodeOrStringProptype() | ||
}; | ||
|
||
render () { | ||
const { className, children } = this.props; | ||
const { buttons, className, children, title } = this.props; | ||
const classes = `${styles.layout} ${className}`; | ||
let actionbar = null; | ||
|
||
if (title || buttons) { | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. 👍 |
||
actionbar = ( | ||
<Actionbar | ||
buttons={ buttons } | ||
title={ title } /> | ||
); | ||
} | ||
|
||
return ( | ||
<div className={ classes }> | ||
{ children } | ||
<div> | ||
{ actionbar } | ||
<div className={ classes }> | ||
{ children } | ||
</div> | ||
</div> | ||
); | ||
} | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
File renamed without changes.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any reason for that ? The
&
is useless, and we might not want to limit todiv
s.padding
instead ofmargin
is what was breaking theevent
pannel in ContractsThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Without that approach, you get a border around the full Page + Actionbar, instead of just the content below. So We are saying - only add border around the direct decendents.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Scrap the above, wrong comment, been too long between writing and review. Will need to go back and see why.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Swapped to margin.
I recall now. The reasson why this was originally introduced (not this PR actually, this was just supposed to move stuff around) it to not make the fixed statusbar at the bottom overlap with the page. Any other solution and you start having funnies across the different pages, e.g. dapps as well.
May be good to have a re-look at this in your fixes branch.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
So this is supposed to be a property of the
.page
class and not its descendants. That's why there ispadding: 0.25em 0.25em 1em 0.25em
for thePage
Component. Anyway, looks good now :)