Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Global Fetch Service #3915

Merged
merged 11 commits into from
Dec 22, 2016
Merged

Global Fetch Service #3915

merged 11 commits into from
Dec 22, 2016

Conversation

tomusdrw
Copy link
Collaborator

Fetching rewritten using reqwest and Future. Dapps, RPC and Updater sharing the same instance of Fetch.
Better fetch API (allowing to stream the response instead of using intermediate temporary file)

Required for #3845
Closes #3495

Tomasz Drwięga added 6 commits December 15, 2016 16:39
Dapps web
38fa18b 
Conflicts:
	dapps/src/apps/fetcher.rs
	dapps/src/handlers/fetch.rs
Rewriting fetch
ac82701
Merge branch 'master' into web-dapps
f089d1f 
Conflicts:
	Cargo.lock
	hash-fetch/Cargo.toml
	hash-fetch/src/client.rs
	rpc/Cargo.toml
	rpc/src/lib.rs
	rpc/src/v1/impls/parity_set.rs
	util/fetch/Cargo.toml
	util/https-fetch/Cargo.toml
Parity-wide fetch service
cd6d6df
Obey the limits and support cancellation.
7386b2b
Removing temporary files.
9b226ba
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Dec 20, 2016
@arkpar
Copy link
Collaborator

arkpar commented Dec 20, 2016

requires OpenSSL now?

@coveralls
Copy link

Coverage Status

Changes Unknown when pulling 7fd62dc on web-dapps into ** on master**.

@tomusdrw
Copy link
Collaborator Author

On linux, yes. I'll try to update the build scripts.

@gavofyork gavofyork modified the milestone: 1.5 Tenuity Dec 20, 2016
@tomusdrw tomusdrw added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 21, 2016
@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Dec 21, 2016
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 86.5% when pulling dc46d9e on web-dapps into b369939 on master.

@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 86.506% when pulling 3e22b73 on web-dapps into b369939 on master.

@arkpar
Copy link
Collaborator

arkpar commented Dec 22, 2016

Looks good in general. Much of the added code is in fact moved from other modules.

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Dec 22, 2016
@gavofyork gavofyork merged commit f0387c3 into master Dec 22, 2016
@gavofyork gavofyork deleted the web-dapps branch December 22, 2016 17:26
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
1.5 Nativity
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @arkpar @coveralls @gavofyork