This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Basic account type #4021
Merged
Basic account type #4021
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rphmeier
added
A0-pleasereview 🤓
tomusdrw
reviewed
Jan 4, 2017
| #[derive(Debug, Clone, PartialEq, Eq)] | ||
| pub struct BasicAccount { | ||
| /// Nonce of the account. | ||
| pub nonce: U256, |
There was a problem hiding this comment.
Do you need to modify the account somewhere?
Wouldn't it be better to have access methods for this?
There was a problem hiding this comment.
Ah, I think it's the only way to create ACC_EMPTY, right? Still I don't really like that you can modify internals freely.
There was a problem hiding this comment.
Well, we could also move ACC_EMPTY into this module. Either way, the type needs to be created somehow, whether with Rlp::decode or BasicAccount::new which would still allow you to alter the internals, just with a read-modify-write, while making it more complicated to instantiate/use in general.
tomusdrw
approved these changes
Jan 4, 2017
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just the decoded RLP in a strongly-typed structure. I have another usecase for this which will be in an upcoming PR.
Differs from PodAccount as it doesn't store the storage/data inline; rather, this represents a leaf of the state trie.