This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix call/estimate_gas #4121
Merged
Fix call/estimate_gas #4121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gavofyork
added
A0-pleasereview 🤓
|
Changes Unknown when pulling 7b93fc9 on fix-est into ** on master**. |
rphmeier
reviewed
Jan 11, 2017
| @@ -673,6 +673,7 @@ impl<C, SN: ?Sized, S: ?Sized, M, EM> Eth for EthClient<C, SN, S, M, EM> where | |||
| let signed = self.sign_call(request)?; | |||
| take_weak!(self.client).estimate_gas(&signed, num.0.into()) | |||
| .map(Into::into) | |||
| .or_else(|_| Ok(0.into())) | |||
| .map_err(errors::from_call_error) | |||
There was a problem hiding this comment.
map_err is now dead code -- should just be unwrap_or(0.into())
gavofyork
changed the title
gavofyork
added
A0-pleasereview 🤓
keorn
added
A8-looksgood 🦄
arkpar
pushed a commit
that referenced
this pull request
Jan 11, 2017
* Return 0 instead of error with out of gas on estimate_gas * Fix stuff up.
gavofyork
pushed a commit
that referenced
this pull request
Jan 11, 2017
* Ignore get_price_info test by default. (#4112) * Auto-detect hex encoded bytes in sha3 (#4108) * Auto-detect hex encoded bytes in sha3 * Using types/isHex * Removing unused imports * Use binary chop to estimate gas accurately (#4100) * Initial sketch. * Building. * Fix a few things. * Fix issue, add tracing. * Address grumbles * Raise upper limit if needed * Fix test. * Fixing decoding API with signatures in names (#4125) * Fix call/estimate_gas (#4121) * Return 0 instead of error with out of gas on estimate_gas * Fix stuff up.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(work around for #4120)