This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Serde 0.9 #4508
Merged
Serde 0.9 #4508
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tomusdrw
added
A0-pleasereview 🤓
rphmeier
reviewed
Feb 10, 2017
json/src/maybe.rs
Outdated
| @@ -38,16 +38,19 @@ impl<T> MaybeEmptyVisitor<T> { | |||
| impl<T> Visitor for MaybeEmptyVisitor<T> where T: Deserialize { | |||
| type Value = MaybeEmpty<T>; | |||
|
|
|||
| fn visit_str<E>(&mut self, value: &str) -> Result<Self::Value, E> where E: Error { | |||
| fn expecting(&self, formatter: &mut fmt::Formatter) -> fmt::Result { | |||
| write!(formatter, "an empty string or encoding of {}", stringify!(T)) | |||
There was a problem hiding this comment.
this just prints "an empty string or encoding of T" regardless of T. You're looking for intrinsics::type_name but it's unstable. rust-lang/rfcs#1428
rphmeier
added
A5-grumble 🔥
rphmeier
added
A0-pleasereview 🤓
:) |
rphmeier
added
A8-looksgood 🦄
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ethabiandjsonrpc-*to latest versions migrated to serde-0.9No more weird errors in
build/rpc/somefile.out:513515:)Closes #3832
Closes #2466