Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

use cargo workspace #5601

Merged
merged 2 commits into from
May 23, 2017
Merged

use cargo workspace #5601

merged 2 commits into from
May 23, 2017

Conversation

debris
Copy link
Collaborator

@debris debris commented May 11, 2017

closes #1582

@debris debris added A0-pleasereview 🤓 Pull request needs code review. M0-build 🏗 Building and build system. M4-core ⛓ Core client code / Rust. labels May 11, 2017
@debris debris requested a review from rphmeier May 11, 2017 15:24
tomusdrw
tomusdrw reviewed May 11, 2017
View reviewed changes
Copy link
Collaborator

@tomusdrw tomusdrw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it change anything?

Cargo.lock
@@ -226,6 +171,14 @@ dependencies = [

[[package]]
name = "clippy"
version = "0.0.90"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you update all clippy versions to the latest release to have it consistent?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in this pr. This line was added automatically by cargo, after I've changed a single line in Cargo.toml - I don't know why.

@debris
Copy link
Collaborator Author

debris commented May 11, 2017

It does change for non root packages

warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/marek/projects/ethcore/parity/secret_store/Cargo.toml
workspace: /Users/marek/projects/ethcore/parity/Cargo.toml
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/marek/projects/ethcore/parity/logger/Cargo.toml
workspace: /Users/marek/projects/ethcore/parity/Cargo.toml
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/marek/projects/ethcore/parity/stratum/Cargo.toml
workspace: /Users/marek/projects/ethcore/parity/Cargo.toml
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/marek/projects/ethcore/parity/updater/Cargo.toml
workspace: /Users/marek/projects/ethcore/parity/Cargo.toml
warning: profiles for the non root package will be ignored, specify profiles at the workspace root:
package:   /Users/marek/projects/ethcore/parity/ipc-common-types/Cargo.toml
workspace: /Users/marek/projects/ethcore/parity/Cargo.toml

Now, root settings are applied everywhere

@arkpar arkpar added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels May 23, 2017
@arkpar arkpar merged commit a8d99ae into master May 23, 2017
@arkpar arkpar deleted the cargo_workspace branch May 23, 2017 10:28
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw left review comments

@rphmeier rphmeier Awaiting requested review from rphmeier

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M0-build 🏗 Building and build system. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Use cargo workspaces when they stabilize
3 participants
@debris @tomusdrw @arkpar