Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Running state test using parity-evm #6355

Merged
merged 5 commits into from
Aug 28, 2017
Merged

Running state test using parity-evm #6355

merged 5 commits into from
Aug 28, 2017

Conversation

tomusdrw
Copy link
Collaborator

Closes #6286

Should be carefuly reviewed cause it changes some stuff in State and Executive.

@tomusdrw tomusdrw added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Aug 22, 2017
@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 26, 2017
@gavofyork gavofyork requested a review from rphmeier August 28, 2017 12:09
@gavofyork gavofyork assigned arkpar and unassigned arkpar Aug 28, 2017
@gavofyork gavofyork requested a review from arkpar August 28, 2017 12:09
@gavofyork
Copy link
Contributor

@rphmeier and @arkpar please give it a look

@arkpar arkpar merged commit f9a08e2 into master Aug 28, 2017
@arkpar
Copy link
Collaborator

arkpar commented Aug 28, 2017

Merged this before seeing @gavofyork's comment. LGTM. Changes in State and Executive are not consensus-related. PR does not touches transactions, only calls.

@arkpar arkpar deleted the evmbin-statetest branch August 28, 2017 12:27
arkpar pushed a commit that referenced this pull request Sep 16, 2017
@tomusdrw @arkpar
Running state test using parity-evm (#6355)
d6d0152 
* Initial version of state tests.

* Refactor state to support tracing.

* Unify TransactResult.

* Add test.
arkpar added a commit that referenced this pull request Sep 16, 2017
@arkpar
[beta] Byzantium updates (#6529)
bb311e8 
* fix modexp bug: return 0 if base=0 (#6424)

* Running state test using parity-evm (#6355)

* Initial version of state tests.

* Refactor state to support tracing.

* Unify TransactResult.

* Add test.

* Byzantium updates
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@rphmeier rphmeier Awaiting requested review from rphmeier

@arkpar arkpar Awaiting requested review from arkpar

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@tomusdrw @gavofyork @arkpar @debris