Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

jsonrpc panics gracefully shutdown client #638

Merged
merged 3 commits into from
Mar 9, 2016
Merged

Conversation

debris
Copy link
Collaborator

@debris debris commented Mar 9, 2016

related #555

@debris debris added the A0-pleasereview 🤓 Pull request needs code review. label Mar 9, 2016
}
}

fn wait_for_exit(client_service: &ClientService) {
fn wait_for_exit(client_service: &ClientService, server_handler: Option<Arc<PanicHandler>>) {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of having two MayPanic (one of them as Option<Arc<PanicHandler>>) you could create just single PanicHandler and use forward_from on client_service and rpc_server (or PanicHandler).

@tomusdrw tomusdrw added A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. and removed A0-pleasereview 🤓 Pull request needs code review. A5-grumble 🔥 Pull request has minor issues that must be addressed before merging. labels Mar 9, 2016
@NikVolf NikVolf mentioned this pull request Mar 9, 2016
@debris debris added A0-pleasereview 🤓 Pull request needs code review. and removed A6-mustntgrumble 💦 Pull request has areas for improvement. The author need not address them before merging. labels Mar 9, 2016
@NikVolf NikVolf added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Mar 9, 2016
tomusdrw added a commit that referenced this pull request Mar 9, 2016
jsonrpc panics gracefully shutdown client
@tomusdrw tomusdrw merged commit 02b23d3 into master Mar 9, 2016
@debris debris deleted the jsonrpc_panic_handle branch March 10, 2016 09:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A8-looksgood 🦄 Pull request is reviewed well.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants