This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
elliptic pairing special cases for zero points #6483
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @cdetrio signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
rphmeier
reviewed
Sep 8, 2017
| @@ -14,7 +14,7 @@ build = "build.rs" | |||
| ansi_term = "0.9" | |||
| bit-set = "0.4" | |||
| bloomchain = "0.1" | |||
| bn = { git = "https://github.com/paritytech/bn" } | |||
| bn = { git = "https://github.com/cdetrio/bn", branch = "mont-repr-fix" } | |||
There was a problem hiding this comment.
could you make a PR to the upstream version so we still only have a paritytech dependency?
rphmeier
reviewed
Sep 8, 2017
| if a_x == Fq::zero() && a_y == Fq::zero() { | ||
| g1_point = G1::zero(); | ||
| } else { | ||
| //g1_point = G1::from(bn::AffineG1::new(a_x, a_y).expect("Invalid a argument - not on curve")); |
rphmeier
added
A5-grumble 🔥
|
Thanks, but this is already fixed in 22269b6 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should fix some elliptic curve test cases. See also paritytech/bn#3