This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Fix Windows NSIS installer not working #6928
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
axelchalon
added
A0-pleasereview 🤓
|
Woops just noticed that this is covered in #6921 ; closing as this is a duplicate. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The Windows NSIS installer currently wouldn't work.
Since #6356, the
--warpargument was removed, and the ordering of the arguments changed (global arguments come before subcommands). So Parity as set up by the installer would throw an error on startup.Not sure how to test this; I don't think that the Windows installer is tested in the CI?