This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
[beta] Backports #8011
Merged
[beta] Backports #8011
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Hardware-wallet fix * More fine-grained initilization of callbacks by vendorID, productID and usb class * Each device manufacturer gets a seperate handle thread each * Replaced "dummy for loop" with a delay to wait for the device to boot-up properly * Haven't been very carefully with checking dependencies cycles etc * Inline comments explaining where shortcuts have been taken * Need to test this on Windows machine and with Ledger (both models) Signed-off-by: niklasad1 <niklasadolfsson1@gmail.com> * Validate product_id of detected ledger devices * closed_device => unlocked_device * address comments * add target in debug * Address feedback * Remove thread joining in HardwareWalletManager * Remove thread handlers in HardwareWalletManager because this makes them unused
* fixed broken logs * bring back old lock order * removed bloom groups from blockchain * revert unrelated changes * simplify blockchain_block_blooms
* fetch: increase max download limit to 64MB * parity: increase download size limit for updater service
tomusdrw
added
A3-inprogress ⏳
|
I'm not working on improving #7974 right now. Let's not backport it as it's not critical and it does not improve anything |
|
we can release this without #7970 #7841 for now. however, compile fails with: |
* Make block generator easier to use * applied review suggestions * rename BlockMetadata -> BlockOptions * removed redundant uses of blockchain generator and genereator.next().unwrap() calls
tomusdrw
added
A8-backport 🕸
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
WASM libraries bump #7970 (please review) WASM libraries bump
Add MCIP-6 Byzyantium transition to Musicoin spec #7841 (please review) Add MCIP-6 Byzyantium transition to Musicoin spec
fix traces, removed bloomchain crate #7979 Fix traces, removed bloomchain crate
Reject too large packets in snapshot sync. #7977 Reject too large packets in snapshot sync.
fixed broken logs #7934 Fixed broken logs
Increase max download limit to 128MB #7965 Increase max download limit to 128MB
Calculate proper keccak256/sha3 using parity. #7953 Calculate proper keccak256/sha3 using parity.
Bump WebSockets #7952 Bump WebSockets
Hardware-wallet/usb-subscribe-refactor #7860 Hardware-wallet/usb-subscribe-refactor-
removed old migrations #7974 Removed old migrations^^^ @debris Migration introduced here takes quite a while. Are you still working on improving that? Do we want that in beta?