This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
Extract the hard dependency on rocksdb from the light client #8034
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
It looks like @tomaka signed our Contributor License Agreement. 👍 Many thanks, Parity Technologies CLA Bot |
debris
approved these changes
Mar 1, 2018
debris
added
A8-looksgood 🦄
rphmeier
approved these changes
Mar 1, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the dependency from the light client towards
kvdb_rocksdb, so that we can use other backends (such askvdb_memory) if we want.Instead of passing the path to the database to the client, we directly open the database from the
paritycrate and pass it toLightClient::new.Ideally we would like to do the same for the full client. However the snapshot creation and restoration is very difficult to convert as it directly manipulates raw files. If this PR is merged, an issue should be opened to be reminded to do this eventually.
cc #7915