Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

cleanup nibbleslice #8915

Merged
merged 1 commit into from
Jun 18, 2018
Merged

cleanup nibbleslice #8915

merged 1 commit into from
Jun 18, 2018

Conversation

debris
Copy link
Collaborator

@debris debris commented Jun 18, 2018 •
edited
Loading

removed redundant and wrong lifetime params and unused code

@debris debris added A0-pleasereview 🤓 Pull request needs code review. A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). M4-core ⛓ Core client code / Rust. labels Jun 18, 2018
@niklasad1 niklasad1 added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jun 18, 2018
dvdplm
dvdplm approved these changes Jun 18, 2018
View reviewed changes
Copy link
Collaborator

@dvdplm dvdplm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I thought this was used for (or because of) the view! macro in view_rlp in ethcore but if tests pass this lgtm

@dvdplm dvdplm merged commit 4ef71f8 into master Jun 18, 2018
dvdplm added a commit that referenced this pull request Jun 18, 2018
@dvdplm
Merge branch 'master' into refactor/hashdb-generic
28358da 
* master:
  cleanup nibbleslice (#8915)
@5chdn 5chdn deleted the nibbleslice_cleanup branch June 18, 2018 10:25
ordian added a commit to ordian/parity that referenced this pull request Jun 20, 2018
@ordian
Merge branch 'master' of https://github.com/paritytech/parity into wa…
dc3ec66 
…rp_sync_on_light_client

* 'master' of https://github.com/paritytech/parity:
  Include node identity in the P2P advertised client version. (openethereum#8830)
  Allow disabling local-by-default for transactions with new config entry (openethereum#8882)
  Allow Poll Lifetime to be configured via CLI (openethereum#8885)
  cleanup nibbleslice (openethereum#8915)
  Hardware-wallets `Clean up things I missed in the latest PR` (openethereum#8890)
  Remove debian/.deb and centos/.rpm packaging scripts (openethereum#8887)
  Remove a weird emoji in new_social docs (openethereum#8913)
  Minor fix in chain supplier and light provider (openethereum#8906)
@5chdn 5chdn added this to the 1.12 milestone Jun 24, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dvdplm dvdplm dvdplm approved these changes

@ordian ordian ordian approved these changes

@niklasad1 niklasad1 niklasad1 approved these changes

Assignees
No one assigned
Labels
A2-insubstantial 👶 Pull request requires no code review (e.g., a sub-repository hash update). A8-looksgood 🦄 Pull request is reviewed well. M4-core ⛓ Core client code / Rust.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.
5 participants
@debris @dvdplm @ordian @niklasad1 @5chdn