Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Changelogs for 1.11.7-stable and 2.0.0-beta #9105

Merged
merged 10 commits into from
Jul 18, 2018
Merged

Changelogs for 1.11.7-stable and 2.0.0-beta #9105

merged 10 commits into from
Jul 18, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Jul 12, 2018 •
edited
Loading

  • docs: mark 1.10 as end-of-life
  • docs: move changelog for 1.11
  • docs: Add changelog for 1.11.7-stable
  • docs: add changelog for 2.0.0-beta
  • docs: add release notes for 2.0.0-beta

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M3-docs 📑 Documentation. labels Jul 12, 2018
@5chdn 5chdn added this to the 2.0 milestone Jul 12, 2018
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 12, 2018
@5chdn 5chdn requested a review from Tbaut July 12, 2018 11:48
@Tbaut
Copy link
Contributor

Tbaut commented Jul 13, 2018 •
edited
Loading

The first lines of the changelog are aggressive and sound like "we removed everything without alternatives". While the reality is more contrasted:

  • Public node ability (`--public-node) has been removed
  • Parity Wallet, a.k.a Browser UI has been removed, head to Parity UI if you want a UI
  • Dapps have been removed, head to Parity UI if you want to see them
  • Windows and MacOS versions are not available as installer anymore and the system trays were removed (#8778). There are still *.exe and *.dpkg binaries.
  • Linux versions are not available as deb-/rpm-packages anymore (#8887). You can use the binaries <-- we need a doc in the Readme for the binaries

@5chdn
Copy link
Contributor Author

5chdn commented Jul 13, 2018

we need a doc in the Readme for the binaries

what do you mean?

There are still *.exe and *.dpkg binaries.

dpkg?

@Tbaut
Copy link
Contributor

Tbaut commented Jul 13, 2018

  1. we need a linux-beginner-friendly explanation of how to DL, extract, make executable and launch parity in the Readme.
  2. pkg maybe? I don't know the extension for mac :)

tomusdrw
tomusdrw reviewed Jul 13, 2018
View reviewed changes
docs/CHANGELOG-1.11.md Outdated
@@ -0,0 +1,643 @@
## Parity [v1.11.7](https://github.com/paritytech/parity/releases/tag/v1.11.7) (2018-07-16)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we highlight couple of important changes to transaction queue that happened in 1.11?
Namely:

  • The pool now limits transactions per-sender (see --tx-queue-per-sender), local transactions also have to obey that limit. Consider increasing the limit via CLI flag when running benchmarks or sending a lot of transactions at once.

  • In case the pool is full transactions received over the network, but originating from accounts that we have private keys for might not get accepted to the pool any more with higher priority. Consider running with larger pool size or submitting the transactions directly on the node via eth_sendRawTransaction.

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 13, 2018
@5chdn
Copy link
Contributor Author

5chdn commented Jul 17, 2018

Thanks @Tbaut @tomusdrw I addressed your comments.

@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Jul 17, 2018
Tbaut
Tbaut approved these changes Jul 17, 2018
View reviewed changes
Copy link
Contributor

@Tbaut Tbaut left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

CHANGELOG.md Outdated
@@ -5,9 +5,9 @@ This is the Parity-Ethereum//v2.0.0-beta release, **YOLO!**
Please note, Parity-Ethereum//v2.0.0 comes with some breaking changes that might be interrupting your usual workflows. Please mind them before upgrading:

- The Parity client is now called _Parity-Ethereum_ to distinguish it from other software we provide, such as [_Parity-Bitcoin_](https://github.com/paritytech/parity-bitcoin/) and [_Parity-Polkadot_](https://github.com/paritytech/polkadot) ([#9052](https://github.com/paritytech/parity/pull/9052)).
- The public node and the user interface (a.k.a. _"Parity Wallet"_) are completely removed from the Parity-Ethereum//v2.0.0 client ([#8758](https://github.com/paritytech/parity/pull/8758), #8783, #8641).
- The public node and the user interface (a.k.a. _"Parity Wallet"_) are completely removed from the Parity-Ethereum//v2.0.0 client ([#8758](https://github.com/paritytech/parity/pull/8758), [#8783](https://github.com/paritytech/parity/pull/8783), [#8641](https://github.com/paritytech/parity/pull/8641)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we mention Parity-UI in order not to scare anyone and get more questions than needed?

CHANGELOG.md Outdated
- Windows and MacOS versions are not available as installer anymore and the system trays were removed ([#8778](https://github.com/paritytech/parity/pull/8778)).
- Linux versions are not available as packages anymore ([#8887](https://github.com/paritytech/parity/pull/8887)). MD5-checksums are completely replaced by SHA256-checksums ([#8884](https://github.com/paritytech/parity/pull/8884)).
- Linux versions are not available as deb-/rpm-packages anymore ([#8887](https://github.com/paritytech/parity/pull/8887)). MD5-checksums are completely replaced by SHA256-checksums ([#8884](https://github.com/paritytech/parity/pull/8884)).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have no doc/explanation about using the binaries right? We should prob. add that to the readme.

@5chdn 5chdn added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 17, 2018
folsen
folsen approved these changes Jul 18, 2018
View reviewed changes
Copy link
Contributor

@folsen folsen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't made sure that everything changed is in there obviously, but text looks good and I assume it's right.

@5chdn
Copy link
Contributor Author

5chdn commented Jul 18, 2018

Of course it's right 🙈 🤣

Thanks

@5chdn 5chdn merged commit 9f90ff2 into master Jul 18, 2018
@5chdn 5chdn deleted the a5-changelog-200 branch July 18, 2018 07:24
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@tomusdrw tomusdrw tomusdrw left review comments

@folsen folsen folsen approved these changes

@Tbaut Tbaut Tbaut approved these changes

Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M3-docs 📑 Documentation.
Projects
None yet
Milestone
2.0 Ethereum
Development

Successfully merging this pull request may close these issues.
4 participants
@5chdn @Tbaut @folsen @tomusdrw