Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Update bootnodes for multiple chains #9174

Merged
merged 1 commit into from Jul 25, 2018
Merged

Update bootnodes for multiple chains #9174

merged 1 commit into from Jul 25, 2018

Conversation

ghost
Copy link

@ghost ghost commented Jul 19, 2018

  • For ETC, ELLA, EXP, Morden, MUSIC

[Chain] Add more bootnodes
d4e4793 
+ For ETC, ELLA, EXP, Morden, MUSIC
@parity-cla-bot
Copy link

It looks like @eosclassicteam signed our Contributor License Agreement. 👍

Many thanks,

Parity Technologies CLA Bot

@ghost ghost mentioned this pull request Jul 19, 2018
Closed
@ghost ghost changed the title [Chain] Add more bootnodes Update bootnodes for multiple chains Jul 19, 2018
@5chdn 5chdn added this to the 2.1 milestone Jul 22, 2018
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. M2-config 📂 Chain specifications and node configurations. labels Jul 22, 2018
@5chdn
Copy link
Contributor

5chdn commented Jul 22, 2018

Where are the bootnodes from?

@ghost
Copy link
Author

ghost commented Jul 22, 2018 •
edited by ghost
Loading

@5chdn As discussed with @debris on my previous PR #9163, I've seperated the PR for better review.

And the source of bootnodes comes from here

ETC: https://raw.githubusercontent.com/ethereumproject/go-ethereum/master/core/config/mainnet_bootnodes.json

Ropsten: https://raw.githubusercontent.com/ethereumproject/go-ethereum/master/core/config/morden_bootnodes.json

ELLA: https://raw.githubusercontent.com/ellaism/parity-config/master/ellaism.json

EXP: https://raw.githubusercontent.com/expanse-org/go-expanse/master/params/bootnodes.go

MUSIC: https://raw.githubusercontent.com/Musicoin/go-musicoin/master/params/bootnodes.go

@debris debris added A8-looksgood 🦄 Pull request is reviewed well. and removed A0-pleasereview 🤓 Pull request needs code review. labels Jul 23, 2018
andresilva
andresilva approved these changes Jul 25, 2018
View reviewed changes
Copy link
Contributor

@andresilva andresilva left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I didn't test these, only briefly looked at the diff and the links for the sources of bootnodes.

@andresilva andresilva requested a review from 5chdn July 25, 2018 15:57
@5chdn 5chdn merged commit 823054d into openethereum:master Jul 25, 2018
@ghost ghost mentioned this pull request Jul 28, 2018
Merged
28 tasks
@ghost ghost deleted the bootnode branch July 31, 2018 10:08
ordian added a commit to ordian/parity that referenced this pull request Jul 31, 2018
@ordian
resolve merge conflicts
294c313 
* 'master' of https://github.com/paritytech/parity:
  removed client error (openethereum#9253)
  Implement EIP-1052 (EXTCODEHASH) and fix several issues in state account cache (openethereum#9234)
  Improve Tracer documentation (openethereum#9237)
  Update Dockerfile (openethereum#9242)
  block cleanup (openethereum#9117)
  Increase the number of sessions. (openethereum#9203)
  add changelog for 1.11.8 stable and 2.0.1 beta (openethereum#9230)
  fix typo (openethereum#9232)
  Fix potential as_usize overflow when casting from U256 in miner (openethereum#9221)
  Allow old blocks from peers with lower difficulty (openethereum#9226)
  Removes duplicate libudev-dev from Dockerfile (openethereum#9220)
  snap: remove ssl dependencies from snapcraft definition (openethereum#9222)
  remove ssl from dockerfiles, closes openethereum#8880 (openethereum#9195)
  Insert PROOF messages for some cases in blockchain (openethereum#9141)
  [Chain] Add more bootnodes (openethereum#9174)
  ethcore: update bn version (openethereum#9217)
  deserialize block only once during verification (openethereum#9161)
  Simple build instruction fix (openethereum#9215)
  Added --tx-queue-no-early-reject flag to disable early tx queue rejects (openethereum#9143)
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers
No reviews
Assignees
No one assigned
Labels
A8-looksgood 🦄 Pull request is reviewed well. M2-config 📂 Chain specifications and node configurations.
Projects
None yet
Milestone
2.1 Whatever
Development

Successfully merging this pull request may close these issues.
4 participants
@parity-cla-bot @5chdn @andresilva @debris