Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Comply EIP210 with the current spec #9272

Closed
wants to merge 2 commits into from
Closed

Comply EIP210 with the current spec #9272

wants to merge 2 commits into from

Conversation

sorpaas
Copy link
Collaborator

@sorpaas sorpaas commented Aug 2, 2018

Change BLOCKHASH contract code to be the current one. It looks like the rest hasn't been changed.

@sorpaas sorpaas added A0-pleasereview 🤓 Pull request needs code review. M4-core ⛓ Core client code / Rust. labels Aug 2, 2018
@sorpaas
Copy link
Collaborator Author

sorpaas commented Aug 3, 2018

Putting this on ice. The new spec looks like breaking some of our current assumptions. ethereum/EIPs#210 (comment)

@sorpaas sorpaas added A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. and removed A0-pleasereview 🤓 Pull request needs code review. labels Aug 3, 2018
@sorpaas
Copy link
Collaborator Author

sorpaas commented Aug 3, 2018

Waiting on ethereum/EIPs#1094

@5chdn 5chdn added this to the 2.1 milestone Aug 21, 2018
@5chdn
Copy link
Contributor

5chdn commented Sep 4, 2018

How to proceed with that now? Is 210 going anywhere anytime soon?

@sorpaas
Copy link
Collaborator Author

sorpaas commented Sep 4, 2018

Still waiting on ethereum/EIPs#1094 actually. After that spec is done, we can modify our code to comply, although EIP-210 itself is not used anywhere right now.

@5chdn 5chdn modified the milestones: 2.1, 2.2 Sep 11, 2018
@5chdn
Copy link
Contributor

5chdn commented Sep 18, 2018

Please reopen once the spec is complete

@5chdn 5chdn closed this Sep 18, 2018
@5chdn 5chdn deleted the sp-eip210 branch November 27, 2018 11:41
@zmitton
Copy link

zmitton commented Feb 16, 2019

@5chdn it seems #1094 has been merged. Does that me this should be re-opened?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
A1-onice 🌨 Pull request is reviewed well, but should not yet be merged. M4-core ⛓ Core client code / Rust.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants