This repository has been archived by the owner on Nov 6, 2020. It is now read-only.
use kvdb-* and parity-snappy crates from crates.io #9441
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
andresilva
added
A3-inprogress ⏳
dvdplm
approved these changes
Aug 30, 2018
andresilva
force-pushed
the
andre/fix-rocksdb-build
branch
from
47f30c3
to
7c3a944
Compare
andresilva
force-pushed
the
andre/fix-rocksdb-build
branch
from
7c3a944
to
eef871c
Compare
|
ARM and Windows builds are fixed (https://gitlab.parity.io/parity/parity-ethereum/-/jobs/96380, https://gitlab.parity.io/parity/parity-ethereum/-/jobs/96382, |
|
Thanks for taking care of this! |
andresilva
force-pushed
the
andre/fix-rocksdb-build
branch
from
92879c8
to
3461fa7
Compare
andresilva
added
A0-pleasereview 🤓
andresilva
force-pushed
the
andre/fix-rocksdb-build
branch
from
0e06f84
to
40f9daf
Compare
|
Everything is green again: https://gitlab.parity.io/parity/parity-ethereum/pipelines/22967 |
5chdn
added
A8-looksgood 🦄
niklasad1
approved these changes
Sep 3, 2018
dvdplm
added a commit
that referenced
this pull request
Sep 4, 2018
* master: evmbin: escape newlines in json errors (#9458) use kvdb-* and parity-snappy crates from crates.io (#9441) Add EIP-1014 transition config flag (#9268) add tags for runner selection of build-linux jobs (#9451) Remove unused BlockStatus::Pending (#9447) ci: only include local paths in coverage script (except target) (#9437) Add POA Networks: Core and Sokol (#9413) docker: install missing dependencies in arm target dockerfiles (#9436) Random small cleanups (#9423)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This should also fix the RocksDB build issues on ARM and Windows since it includes (paritytech/rust-rocksdb#19). I want to run a CI job on ARM and Windows to make sure it is passing so I'll label this as inprogress until that's done.