Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

docs: add changelogs for 1.11.10, 1.11.11, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.1.0, and 2.1.1 #9554

Merged
merged 17 commits into from
Sep 20, 2018
Merged

docs: add changelogs for 1.11.10, 1.11.11, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.1.0, and 2.1.1 #9554

merged 17 commits into from
Sep 20, 2018

Conversation

5chdn
Copy link
Contributor

@5chdn 5chdn commented Sep 13, 2018 •
edited
Loading

  • docs: prepare changelog for 2.1.0 beta
  • docs: move changelog for 2.0.x to stable
  • docs: add changelog for legacy 1.11.x
  • docs: add release notes for 2.0.x beta releases
  • docs: mark 1.11 end of life
  • docs: add release notes for 2.0.5 stable
  • docs: add release notes for 2.1.0 beta
  • docs: add release notes for 2.0.6 stable
  • docs: add release notes for 2.1.1 beta

and:

  • ci: ignore docs in tests

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. M3-docs 📑 Documentation. labels Sep 13, 2018
@5chdn 5chdn added this to the 2.2 milestone Sep 13, 2018
@5chdn 5chdn added the M1-ci 🙉 Continuous integration. label Sep 13, 2018
@ghost
Copy link

ghost commented Sep 14, 2018

EOL for 1.11 is too fast! Didn't finished my sync yet 😂 https://stats.ethbrowser.io/

debris
debris previously requested changes Sep 17, 2018
View reviewed changes
Copy link
Collaborator

@debris debris left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good except merge conflicts

scripts/gitlab/test.sh.orig Outdated
=======

export RUST_FILES_MODIFIED="$(git --no-pager diff --name-only $GIT_COMPARE...$CI_COMMIT_SHA | grep -v -e ^\\. -e ^LICENSE -e ^README.md -e ^test.sh -e ^scripts/ | wc -l | tr -d ' ')"
>>>>>>> a5-config-constantinople
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

merge conflicts are still here

@5chdn
Copy link
Contributor Author

5chdn commented Sep 17, 2018

Ooops 🤦‍♀️

@5chdn 5chdn force-pushed the a5-docs-changelogs branch from bf6ef64 to 372d9e9 Compare September 17, 2018 10:14
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 17, 2018
sorpaas
sorpaas reviewed Sep 18, 2018
View reviewed changes
CHANGELOG.md Outdated
- Generalized `blockReward` and `difficultyBombDelays` config ([#9480](https://github.com/paritytech/parity-ethereum/pull/9480)): This removes `eip649*` parameters from chain specs and allows `blockReward` to accept `multi`. Please review your chain-specs!
- Implement EIP234 `block_hash` for `eth_getLogs` ([#9256](https://github.com/paritytech/parity-ethereum/pull/9256)): If `block_hash` and `from_block`/`to_block` present, return error. This also changes `eth_getLogs` to return error if any of `block_hash`/`from_block`/`to_block` cannot be found.
- The default `gas_floor_target` was increased to `8_000_000`, the default `gas_cap` to `10_000_000`.
- Comply EIP-86 with the new definition ([#9140](https://github.com/paritytech/parity-ethereum/pull/9140)). Note that this is backward incompatible, with the assumption that none (or not many) working chains have attempted to set the `eip86Transition` flag, because it's not really useful by itself.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

EIP-86 flag has been removed (and replaced by EIP-1014) in #9268. And looks like we did include it in v2.1.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#9268 says "Add EIP-1014 transition config flag" - how could I know?

Please save everyone some time by adding proper labels and pull request descriptions. I can't look at the code diff of 150 PRs when compiling the changelog.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apparently that PRs' scope was changed because of some issues -- there was indeed a description: #9268 (comment)

But yeah I agree this can be done better, and I should have added releasenote tag / put a reference to that comment in issue description.

@5chdn 5chdn added A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. and removed A0-pleasereview 🤓 Pull request needs code review. labels Sep 18, 2018
@5chdn 5chdn added A0-pleasereview 🤓 Pull request needs code review. and removed A3-inprogress ⏳ Pull request is in progress. No review needed at this stage. labels Sep 18, 2018
@5chdn 5chdn changed the title docs: add changelogs for 1.11.10, 1.11.11, 2.0.3, 2.0.4, 2.0.5, and 2.1.0 docs: add changelogs for 1.11.10, 1.11.11, 2.0.3, 2.0.4, 2.0.5, 2.0.6, 2.1.0, and 2.1.1 Sep 19, 2018
@ordian
Copy link
Collaborator

ordian commented Sep 19, 2018 •
edited
Loading

I for one would prefer having oneline (git log --oneline) messages in changelog to keep it short and informative (messages like "Fix tests" don't really help and nobody reads them anyway).

niklasad1
niklasad1 reviewed Sep 19, 2018
View reviewed changes
CHANGELOG.md Outdated
- Check in flight FindNode before pings
- Add `deprecated` to deprecated_echo_hash
- Refactor `discovery_round` branching
- Net_version caches network_id to avoid redundant aquire of sync read lock ([#9544](https://github.com/paritytech/parity-ethereum/pull/9544))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/aquire/acquire

niklasad1
niklasad1 reviewed Sep 19, 2018
View reviewed changes
CHANGELOG.md Outdated
- Ethcore: don't validate difficulty when ignoring seal check
- Ethcore: fix block verification test
- Ethcore: document skipped verifications when check_seal is disabled
- [light/jsonrpc] Provide the actual account for `eth_coinbase` RPC and unify error handeling for light and full client ([#9383](https://github.com/paritytech/parity-ethereum/pull/9383))
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

s/handeling/handling (oops I'm responsible for that one)

@5chdn 5chdn merged commit 403c07c into master Sep 20, 2018
@5chdn 5chdn deleted the a5-docs-changelogs branch September 20, 2018 08:59
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@niklasad1 niklasad1 niklasad1 approved these changes

@sorpaas sorpaas sorpaas approved these changes

@debris debris debris left review comments

Assignees
No one assigned
Labels
A0-pleasereview 🤓 Pull request needs code review. M1-ci 🙉 Continuous integration. M3-docs 📑 Documentation.
Projects
None yet
Milestone
2.2
Development

Successfully merging this pull request may close these issues.
5 participants
@5chdn @ordian @debris @sorpaas @niklasad1