Skip to content
This repository has been archived by the owner on Nov 6, 2020. It is now read-only.

Test fix for windows cache name... #9658

Merged
merged 2 commits into from
Sep 28, 2018
Merged

Test fix for windows cache name... #9658

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
aef9479
Test fix for windows cache name...
ddorgan Sep 27, 2018
d889776
Fix variable name.
ddorgan Sep 27, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions .gitlab-ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,7 +100,7 @@ test-android-rust-stable:
test-windows-rust-stable:
stage: test
cache:
key: "%CI_JOB_NAME%"
key: "${CI_JOB_NAME}"
paths:
- "%CI_PROJECT_DIR%/target/"
- "%CI_PROJECT_DIR%/cargo/"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we need to change the notation everywhere from %VAR% to ${VAR} ?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As far as I understand — no, since scripts for caching are evaluated in linux environment (on a Gitlab server side) when we convert yaml into an actual executable; but paths are expanded on the target machine when it's actually executed.

But I might as well be mistaken

Expand Down Expand Up @@ -208,7 +208,7 @@ build-windows-msvc-x86_64:
stage: build
only: *releaseable_branches
cache:
key: "%CI_JOB_NAME%"
key: "${CI_JOB_NAME}"
paths:
- "%CI_PROJECT_DIR%/target/"
- "%CI_PROJECT_DIR%/cargo/"
Expand Down