Add the kip6 feature gate #15
Conversation
Cargo.toml
Outdated
| kip4 = [] | ||
| std = ["pwasm-std/std", "parity-hash/std", "uint/std", "byteorder/std"] | ||
| kip6 = [] | ||
| std = ["kip6", "pwasm-std/std", "parity-hash/std", "uint/std", "byteorder/std"] |
There was a problem hiding this comment.
hm could you explain why std requires kip6?
There was a problem hiding this comment.
why not? std feature is a default, but with std
Cargo.toml
Outdated
| @@ -30,6 +30,7 @@ version = "1.2.2" | |||
| default-features = false | |||
|
|
|||
| [features] | |||
| default = [] | |||
| default = ["kip6"] | |||
There was a problem hiding this comment.
should be default only after the fork?
There was a problem hiding this comment.
I don't think it's make sense. The binaries will not change until user will use it (it'll optimized out). So the final decision will be still in hands of user and it will depend only on the code user wrote, regardless if kip6 feature is enabled or disabled.
There was a problem hiding this comment.
i don't see any point in feature gate if it is on by default
There was a problem hiding this comment.
I don't see either. That's why I had with question openethereum/parity-ethereum#9357 (comment)
Maybe some people would consider it useful, but I can't imagine what kind of case that would be.
There was a problem hiding this comment.
I don't like the idea to force users to pass this feature for no reason in every contract as well.
There was a problem hiding this comment.
They won't need to pass it until the fork is done with the exception if they use custom chain spec.
And after the fork, it will be the default, so they won't need to pass it again, right?
There was a problem hiding this comment.
So the idea behind make it the "default" feature is that by "default" user don't have to care either pwasm-ethereum has this extern or not (see #15 (comment))
There was a problem hiding this comment.
"default" configuration is the kind of configuration that won't allow a user to generate invalid binaries for kovan network
There was a problem hiding this comment.
And after the fork, it will be the default, so they won't need to pass it again, right?
I just think that we have to care about this, because again:
it will depend only on the code user wrote, regardless if kip6 feature is enabled or disabled.
There was a problem hiding this comment.
"default" configuration is the kind of configuration that won't allow a user to generate invalid binaries for kovan network
ok, that's a good argument.
lexfrl
changed the title
I'd like to make
kip4as a default as well, but don't sure