This repository has been archived by the owner on Feb 14, 2021. It is now read-only.
Fixed-size data types use #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
NikVolf
reviewed
Sep 7, 2017
src/ext.rs
Outdated
| @@ -81,7 +84,7 @@ pub fn create(endowment: &[u8; 32], code: &[u8]) -> Result<[u8; 20], Error> { | |||
| } | |||
| } | |||
|
|
|||
| pub fn call(address: &[u8; 20], value: &[u8; 32], input: &[u8], result: &mut [u8]) -> Result<(), Error> { | |||
| pub fn call(address: &Address, value: &[u8; 32], input: &[u8], result: &mut [u8]) -> Result<(), Error> { | |||
There was a problem hiding this comment.
U256 on value?
should convert then to bigendian and pass
NikVolf
reviewed
Sep 7, 2017
src/ext.rs
Outdated
| unsafe { external::suicide(refund.as_ptr()); } | ||
| } | ||
|
|
||
| pub fn create(endowment: &[u8; 32], code: &[u8]) -> Result<[u8; 20], Error> { | ||
| let mut result = [0u8; 20]; | ||
| pub fn create(endowment: &[u8; 32], code: &[u8]) -> Result<Address, Error> { |
|
block_hash should also return H256 |
|
gas_limit and difficulty should return U256 |
|
Commit messages should be little more meaningful or i'll squash them |
NikVolf
reviewed
Sep 7, 2017
src/lib.rs
Outdated
| let mut value = [0u8; 32]; | ||
| value.copy_from_slice(&self.raw[60..92]); | ||
| value | ||
| U256::from(value) |
There was a problem hiding this comment.
better explicitly use from_big_endian here
I know, I'm planning to squash them before merge |
- changed interfaces of storage, ext and ParamsView to use H160, H256 and bignum::U256 primitives
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
use of H256 and H160 instead of plain u8-arrays