Initial fixed-size data structures impl #5

lexfrl · 2017-09-01T11:21:07Z

Implement from hex string/to hex string format

NikVolf · 2017-09-01T11:44:03Z

src/hash.rs

+			}
+		}
+
+		// impl str::FromStr for $from {


Remove or uncomment please )

I'm going to implement it today

NikVolf · 2017-09-04T16:27:09Z

src/hash.rs

+}
+
+/// Get the SHA3 (i.e. Keccak) hash of the empty bytes string.
+pub const SHA3_EMPTY: H256 = H256( [0xc5, 0xd2, 0x46, 0x01, 0x86, 0xf7, 0x23, 0x3c, 0x92, 0x7e, 0x7d, 0xb2, 0xdc, 0xc7, 0x03, 0xc0, 0xe5, 0x00, 0xb6, 0x53, 0xca, 0x82, 0x27, 0x3b, 0x7b, 0xfa, 0xd8, 0x04, 0x5d, 0x85, 0xa4, 0x70] );


No need in this PR for this

NikVolf · 2017-09-04T16:27:16Z

src/hash.rs

+pub const SHA3_EMPTY: H256 = H256( [0xc5, 0xd2, 0x46, 0x01, 0x86, 0xf7, 0x23, 0x3c, 0x92, 0x7e, 0x7d, 0xb2, 0xdc, 0xc7, 0x03, 0xc0, 0xe5, 0x00, 0xb6, 0x53, 0xca, 0x82, 0x27, 0x3b, 0x7b, 0xfa, 0xd8, 0x04, 0x5d, 0x85, 0xa4, 0x70] );
+
+/// The SHA3 of the RLP encoding of empty data.
+pub const SHA3_NULL_RLP: H256 = H256( [0x56, 0xe8, 0x1f, 0x17, 0x1b, 0xcc, 0x55, 0xa6, 0xff, 0x83, 0x45, 0xe6, 0x92, 0xc0, 0xf8, 0x6e, 0x5b, 0x48, 0xe0, 0x1b, 0x99, 0x6c, 0xad, 0xc0, 0x01, 0x62, 0x2f, 0xb5, 0xe3, 0x63, 0xb4, 0x21] );


NikVolf · 2017-09-04T16:27:21Z

src/hash.rs

+pub const SHA3_NULL_RLP: H256 = H256( [0x56, 0xe8, 0x1f, 0x17, 0x1b, 0xcc, 0x55, 0xa6, 0xff, 0x83, 0x45, 0xe6, 0x92, 0xc0, 0xf8, 0x6e, 0x5b, 0x48, 0xe0, 0x1b, 0x99, 0x6c, 0xad, 0xc0, 0x01, 0x62, 0x2f, 0xb5, 0xe3, 0x63, 0xb4, 0x21] );
+
+/// The SHA3 of the RLP encoding of empty list.
+pub const SHA3_EMPTY_LIST_RLP: H256 = H256( [0x1d, 0xcc, 0x4d, 0xe8, 0xde, 0xc7, 0x5d, 0x7a, 0xab, 0x85, 0xb5, 0x67, 0xb6, 0xcc, 0xd4, 0x1a, 0xd3, 0x12, 0x45, 0x1b, 0x94, 0x8a, 0x74, 0x13, 0xf0, 0xa1, 0x42, 0xfd, 0x40, 0xd4, 0x93, 0x47] );


NikVolf · 2017-09-04T16:27:41Z

src/hash.rs

+
+
+/// Return `s` without the `0x` at the beginning of it, if any.
+pub fn clean_0x(s: &str) -> &str {


this is not needed
the same the function that uses it

NikVolf · 2017-09-04T16:28:34Z

src/hash.rs

+            }
+        }
+
+        impl fmt::Display for $from {


Not sure if we want to use parity-specific formatting for hex here

better use the same as in Debug impl

NikVolf · 2017-09-04T16:29:25Z

src/hash.rs

+        }
+
+        impl Copy for $from {}
+        #[cfg_attr(feature="dev", allow(expl_impl_clone_on_copy))]


We don't have any dev features, should be removed and included or not included without dependency on it

lexfrl requested a review from NikVolf September 1, 2017 11:21

NikVolf reviewed Sep 1, 2017

View reviewed changes

fixed-size structures implemented

fd08d3a

lexfrl force-pushed the hash branch from d842f74 to fd08d3a Compare September 4, 2017 16:19

NikVolf reviewed Sep 4, 2017

View reviewed changes

cleanup, unused attribs removed, fix formatting

aa3d251

NikVolf merged commit 916ebb6 into master Sep 4, 2017

NikVolf deleted the hash branch September 4, 2017 17:17

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Initial fixed-size data structures impl #5

Initial fixed-size data structures impl #5

lexfrl commented Sep 1, 2017 •

edited

Loading

NikVolf Sep 1, 2017

lexfrl Sep 1, 2017 •

edited

Loading

NikVolf Sep 4, 2017

NikVolf Sep 4, 2017

NikVolf Sep 4, 2017

NikVolf Sep 4, 2017

NikVolf Sep 4, 2017

NikVolf Sep 4, 2017



		/// Return `s` without the `0x` at the beginning of it, if any.
		pub fn clean_0x(s: &str) -> &str {

Initial fixed-size data structures impl #5

Initial fixed-size data structures impl #5

Conversation

lexfrl commented Sep 1, 2017 • edited Loading

NikVolf Sep 1, 2017

Choose a reason for hiding this comment

lexfrl Sep 1, 2017 • edited Loading

Choose a reason for hiding this comment

NikVolf Sep 4, 2017

Choose a reason for hiding this comment

NikVolf Sep 4, 2017

Choose a reason for hiding this comment

NikVolf Sep 4, 2017

Choose a reason for hiding this comment

NikVolf Sep 4, 2017

Choose a reason for hiding this comment

NikVolf Sep 4, 2017

Choose a reason for hiding this comment

NikVolf Sep 4, 2017

Choose a reason for hiding this comment

lexfrl commented Sep 1, 2017 •

edited

Loading

lexfrl Sep 1, 2017 •

edited

Loading