-
Notifications
You must be signed in to change notification settings - Fork 12
feat(ids): Lower probability of same id twice on page. - OEL-3642 #666
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
🚀 Deployed on https://preview-666--oelibrary.netlify.app |
drishu
requested changes
Apr 24, 2025
Collaborator
drishu
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We are missing the in-page navigation
drishu
approved these changes
May 7, 2025
tibi2303
added a commit
that referenced
this pull request
May 8, 2025
* feat(themes): Added ss-2 support for all themes. - OEL-3704 (#655) * feat(select): Added support for slim select single value. - OEL-3081 (#651) * feat(select): Added support for slim select single value. - OEL-3801 * feat(select): Update install. - OEL-3801 * Install gz file update * Added install gz to gitignore. * feat(utility): Improved negative spacings. - OEL-3775 (#662) * feat(slim-select): Removed patch for slim-select 2 and applied in js directly. (#658) * feat(slim-select): Removed patch for slim-select 2 and applied in js directly. * Removed install gz * feat(accessibility): Removed aria-exanded from modals and rewrote gallery js. - OEL-3726 (#660) * feat(accessibility): Removed aria-exanded from modals. - OEL-3726 * feat(accessibility): Rewrote gallery js for keyboard navigation. - OEL-3726 * chore(deps): bump @babel/runtime from 7.26.9 to 7.26.10 in /builder (#649) Bumps [@babel/runtime](https://github.com/babel/babel/tree/HEAD/packages/babel-runtime) from 7.26.9 to 7.26.10. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.26.10/packages/babel-runtime) --- updated-dependencies: - dependency-name: "@babel/runtime" dependency-type: direct:production ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * feat(multiselect): Changed placeholder color. - OEL-3727 (#659) * feat(multiselect): Changed placeholder color. - OEL-3727 * OEL-3727: Updated lock file. * OEL-3752: Rollback slim-select 2 patch. (#668) * OEL-3602: Timeline vertical align. (#639) * OEL-3602: Timeline vertical align. * Apply suggestions from code review Co-authored-by: Szilagyi Andras <aszilagyi@live.com> --------- Co-authored-by: Szilagyi Andras <aszilagyi@live.com> * feat(accordion): Limit to 80ch per row. - OEL-3656 (#665) * feat(accordion): Limit to 80ch per row. - OEL-3656 * OEL-3656: Added also accordion button to limit. * OEL-3656: changed item.title merge. * feat(ids): Lower probability of same id twice on page. - OEL-3642 (#666) * feat(ids): Lower probability of same id twice on page. - OEL-3642 * OEL-3642: Inpage increased random. * Release 1.10.1 (#675) * Release 1.10.1 * Changelog * Update yarn.lock --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Dumitru Tiberiu-Andrei <Tiberiu-Andrei.DUMITRU@ext.ec.europa.eu> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Julien Tekrane <julien-@users.noreply.github.com> Co-authored-by: Szilagyi Andras <aszilagyi@live.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.