EWPP-4991: Surpress deprecated interfaces. #3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
approved these changes
Jan 20, 2025
AaronGilMartinez
requested changes
Jan 23, 2025
| @@ -8,3 +8,6 @@ parameters: | |||
| - "#^Plugin definitions cannot be altered.#" | |||
| - "#^Class .* extends @internal class#" | |||
| - identifier: missingType.iterableValue | |||
|
|
|||
| # Too many issues with supporting multiple Drupal versions. | |||
| - identifier: class.implementsDeprecatedInterface | |||
There was a problem hiding this comment.
This change will surpress an error for the components/projects using the library (unless they have their own neon file).
To avoid the problem on components that supports multiple versions I see two solutions:
- Add this specific configuration in the projects where is needed.
- Set the configuration of the code-review-drupal library, but I would try to warn people about it, this may go unnoticed. Maybe readme.
I prefer first option but I lack a bit of context here, like how many components/proyects are having this issue.
There was a problem hiding this comment.
we did point 1 and realised its to many of them, and proposed this PR @AaronGilMartinez
There was a problem hiding this comment.
In that case, maybe adding a warning in the readme is not bad idea.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.