EWPP-760: Configurable sort options. #114
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
imanoleguskiza
previously approved these changes
Oct 25, 2021
sergepavle
previously approved these changes
Oct 26, 2021
| 'search_api', | ||
| 'search_api_db', | ||
| 'oe_list_pages_event_subscriber_test', | ||
| 'oe_list_pages_filters_test', |
There was a problem hiding this comment.
Suggested change
| 'oe_list_pages_filters_test', |
| * Constructs a new ListPageSourceAlterEvent. | ||
| * | ||
| * @param string $entity_type | ||
| * The The entity type. |
There was a problem hiding this comment.
Suggested change
| * The The entity type. | |
| * The entity type. |
Comment on lines
+586
to
+587
| $default_sort = $bundle->getThirdPartySetting('oe_list_pages', 'default_sort', []); | ||
| return $default_sort; |
There was a problem hiding this comment.
Suggested change
| $default_sort = $bundle->getThirdPartySetting('oe_list_pages', 'default_sort', []); | |
| return $default_sort; | |
| return $bundle->getThirdPartySetting('oe_list_pages', 'default_sort', []); |
imanoleguskiza
previously approved these changes
Nov 5, 2021
sergepavle
previously approved these changes
Nov 8, 2021
imanoleguskiza
dismissed stale reviews from sergepavle and themself
via
4c161e7
imanoleguskiza
force-pushed
the
EWPP-760
branch
from
bb7eb87 to
4c161e7
Compare
sergepavle
approved these changes
Jan 11, 2022
imanoleguskiza
approved these changes
Jan 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.