EWPP-1644: Open vocabulary association facet translations. #115
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
force-pushed
the
EWPP-1644
branch
2 times, most recently
from
54f61a6 to
092cd60
Compare
sergepavle
requested changes
Oct 21, 2021
modules/oe_list_pages_open_vocabularies/oe_list_pages_open_vocabularies.post_update.php
Outdated
Show resolved
Hide resolved
...les/oe_list_pages_open_vocabularies/src/EventSubscriber/AssociationTranslationSubscriber.php
Show resolved
Hide resolved
...t_pages_open_vocabularies/tests/src/Kernel/ListPagesSearchApiConfiguratorTranslationTest.php
Outdated
Show resolved
Hide resolved
| // created. | ||
| $this->container->get('kernel')->rebuildContainer(); | ||
| /** @var \Drupal\facets\FacetInterface $facet_1 */ | ||
| $facet = Facet::load($facet_id_one); |
There was a problem hiding this comment.
Suggested change
| $facet = Facet::load($facet_id_one); | |
| $facet_one = Facet::load($facet_id_one); |
...t_pages_open_vocabularies/tests/src/Kernel/ListPagesSearchApiConfiguratorTranslationTest.php
Show resolved
Hide resolved
...t_pages_open_vocabularies/tests/src/Kernel/ListPagesSearchApiConfiguratorTranslationTest.php
Show resolved
Hide resolved
sergepavle
previously approved these changes
Oct 25, 2021
sergepavle
approved these changes
Nov 9, 2021
hernani
approved these changes
Nov 9, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does 2 things: