EWPP-2570: Allow to alter facet creation. #155
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
requested changes
Oct 17, 2022
modules/oe_list_pages_open_vocabularies/src/Event/SearchApiConfigurationEvents.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_open_vocabularies/src/Event/SearchApiFacetUpdateEvent.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_open_vocabularies/src/Event/SearchApiFacetUpdateEvent.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_open_vocabularies/src/Event/SearchApiFacetUpdateEvent.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_open_vocabularies/src/Event/SearchApiFacetUpdateEvent.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_open_vocabularies/src/Event/SearchApiFacetUpdateEvent.php
Outdated
Show resolved
Hide resolved
upchuk
previously approved these changes
Oct 18, 2022
nagyad
previously approved these changes
Oct 18, 2022
hernani
reviewed
Apr 27, 2023
| @@ -133,7 +143,11 @@ public function updateConfig(OpenVocabularyAssociationInterface $association, st | |||
| $facet->setFacetSourceId($list_source->getSearchId()); | |||
| $facet->setWidget('oe_list_pages_multiselect', []); | |||
| $facet->setFieldIdentifier($property_path); | |||
| $facet->save(); | |||
|
|
|||
There was a problem hiding this comment.
This event is also thrown if the vocabulary association is being edited so we should either rename it or make it only to be fired for new associations being saved.
upchuk
previously approved these changes
Jun 21, 2023
upchuk
approved these changes
Jun 21, 2023
22Alexandra
approved these changes
Jun 21, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands