EWPP-3658: Link list display plugin integration. #196
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
force-pushed
the
EWPP-3658
branch
4 times, most recently
from
6224ef0 to
d7f90f2
Compare
upchuk
force-pushed
the
EWPP-3658
branch
2 times, most recently
from
ce07df0 to
71447c6
Compare
upchuk
force-pushed
the
EWPP-3658
branch
2 times, most recently
from
f387ddc to
52d2218
Compare
hernani
reviewed
Nov 28, 2023
|
|
||
| ## How it works | ||
|
|
||
| The module acts in two place. |
hernani
reviewed
Dec 7, 2023
|
|
||
| $display_plugin_options = $this->linkDisplayPluginManager->getPluginsAsOptions('dynamic', 'list_pages'); | ||
|
|
||
| $form['display']['plugin'] = [ |
There was a problem hiding this comment.
Maybe would be better to have this new configuration options inside a fieldset so all display config options are inside the same set.
| $page->selectFieldOption('Display', 'Titles with optional link'); | ||
| $this->assertSession()->assertWaitOnAjaxRequest(); | ||
| $this->assertSession()->pageTextNotContains('This plugin does not have any configuration options.'); | ||
| // By default, the Link checkbox is checked,. |
sergepavle
reviewed
Dec 12, 2023
modules/oe_list_pages_link_list_displays/src/ListDisplaySelectionBuilder.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_link_list_displays/oe_list_pages_link_list_displays.module
Show resolved
Hide resolved
modules/oe_list_pages_link_list_displays/src/OeListPagesLinkListDisplaysServiceProvider.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_link_list_displays/src/ListDisplaySelectionBuilder.php
Outdated
Show resolved
Hide resolved
modules/oe_list_pages_link_list_displays/src/ListDisplaySelectionBuilder.php
Outdated
Show resolved
Hide resolved
upchuk
force-pushed
the
EWPP-3658
branch
2 times, most recently
from
cf69530 to
d8058a4
Compare
sergepavle
approved these changes
Jan 12, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.