OPENEUROPA-3373: Add query functionality #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
requested changes
Jul 10, 2020
hernani
commented
Jul 16, 2020
upchuk
requested changes
Jul 23, 2020
src/ListSource.php
Outdated
| * | ||
| * @var string | ||
| */ | ||
| protected $bundleFieldId; |
There was a problem hiding this comment.
This is not a field. Let's call it $bundleKey and the comment:
The bundle entity key used to reference the entity bundle.
src/ListQueryOptions.php
Outdated
| * | ||
| * @param array $ignored_filters | ||
| * The ignored filters. | ||
| * @param array $preset_filters_values |
There was a problem hiding this comment.
Let's be consistent $present_filters. Why we append "values"? Also method name
upchuk
approved these changes
Jul 23, 2020
sergepavle
approved these changes
Jul 23, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-[Insert ticket number here]
Description
[Insert description here]
Change log
Commands