OPENEUROPA-1126: Use logger factory as a service. #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
upchuk
requested changes
Aug 22, 2018
| /** | ||
| * {@inheritdoc} | ||
| * | ||
| * @var \Drupal\Core\Logger\ |
There was a problem hiding this comment.
Incorrect namespace here in the docblock.
| // Get id from settings.php! | ||
| $this->config = $configFactory->get(AnalyticsEventInterface::CONFIG_NAME); | ||
| $this->requestStack = $requestStack; | ||
| $this->loggerFactory = $loggerFactory; |
There was a problem hiding this comment.
I would not set logger factory in the class, but directly the channel.
$this->logger = $loggerFactory->get('oe_webtools');
And then you have $logger everywhere you need to log.
| $factory | ||
| ->get('default') | ||
| $this->loggerFactory | ||
| ->get('oe_webtools') | ||
| ->debug('The setting "' . AnalyticsEventInterface::SITE_ID . '" is missing from settings file.'); |
There was a problem hiding this comment.
I would make this a warning rather than debug no?
upchuk
approved these changes
Aug 23, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1126