EWPP-842: Allow chart and racing services for webtols chart widget. #152
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sergepavle
previously approved these changes
Mar 18, 2021
upchuk
previously requested changes
Mar 19, 2021
| @@ -46,7 +46,7 @@ public function validate($value, Constraint $constraint) { | |||
| } | |||
|
|
|||
| // Add violation in case incorrect services. | |||
| if (!isset($snippet['service']) || $snippet['service'] !== $widget_types[$constraint->widgetType]['service']) { | |||
| if (!isset($snippet['service']) || !in_array($snippet['service'], $widget_types[$constraint->widgetType]['services'])) { | |||
There was a problem hiding this comment.
Also BC issue here. Check for the presence of services and if not, case service to an array and use that. This is in case someone extended the source class.
yenyasinn
reviewed
Mar 19, 2021
| @@ -125,6 +125,7 @@ public function getWidgetTypes() { | |||
| 'chart' => [ | |||
| 'name' => $this->t('Chart'), | |||
| 'service' => 'charts', | |||
| 'services' => ['chart', 'racing'], | |||
There was a problem hiding this comment.
If service is deprecated then need to provide services parameter for each widget type as was done in the first commits.
There was a problem hiding this comment.
yes, all of them need to get services
22Alexandra
force-pushed
the
EWPP-842
branch
3 times, most recently
from
c727c21 to
e2dab98
Compare
sergepavle
previously approved these changes
Mar 19, 2021
yenyasinn
previously approved these changes
Mar 23, 2021
upchuk
requested changes
Apr 12, 2021
upchuk
approved these changes
Apr 12, 2021
sergepavle
approved these changes
Apr 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.