OPENEUROPA-1414: Add support for multilingual aliases on Webtools Analytics rules. #27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brummbar
requested changes
Jan 8, 2019
...modules/oe_webtools_analytics_rules/src/EventSubscriber/WebtoolsAnalyticsEventSubscriber.php
Outdated
Show resolved
Hide resolved
...alytics/modules/oe_webtools_analytics_rules/config/schema/webtools_analytics_rule.schema.yml
Outdated
Show resolved
Hide resolved
..._webtools_analytics/modules/oe_webtools_analytics_rules/src/Entity/WebtoolsAnalyticsRule.php
Outdated
Show resolved
Hide resolved
...ebtools_analytics/modules/oe_webtools_analytics_rules/src/Form/WebtoolsAnalyticsRuleForm.php
Show resolved
Hide resolved
...tools_analytics/modules/oe_webtools_analytics_rules/src/WebtoolsAnalyticsRuleListBuilder.php
Outdated
Show resolved
Hide resolved
...modules/oe_webtools_analytics_rules/src/EventSubscriber/WebtoolsAnalyticsEventSubscriber.php
Outdated
Show resolved
Hide resolved
ademarco
reviewed
Jan 10, 2019
...modules/oe_webtools_analytics_rules/src/EventSubscriber/WebtoolsAnalyticsEventSubscriber.php
Outdated
Show resolved
Hide resolved
ademarco
reviewed
Jan 10, 2019
..._analytics/modules/oe_webtools_analytics_rules/src/Entity/WebtoolsAnalyticsRuleInterface.php
Outdated
Show resolved
Hide resolved
…tions and changed approach.
sergepavle
force-pushed
the
OPENEUROPA-1414
branch
from
4c0fff6 to
052fef6
Compare
brummbar
requested changes
Jan 15, 2019
...modules/oe_webtools_analytics_rules/src/EventSubscriber/WebtoolsAnalyticsEventSubscriber.php
Outdated
Show resolved
Hide resolved
..._webtools_analytics/modules/oe_webtools_analytics_rules/src/Entity/WebtoolsAnalyticsRule.php
Outdated
Show resolved
Hide resolved
...modules/oe_webtools_analytics_rules/src/EventSubscriber/WebtoolsAnalyticsEventSubscriber.php
Outdated
Show resolved
Hide resolved
...ebtools_analytics/modules/oe_webtools_analytics_rules/src/Form/WebtoolsAnalyticsRuleForm.php
Outdated
Show resolved
Hide resolved
nagyad
previously approved these changes
Jan 15, 2019
sergepavle
force-pushed
the
OPENEUROPA-1414
branch
from
c303015 to
7c0dc48
Compare
upchuk
force-pushed
the
OPENEUROPA-1414
branch
from
ba92047 to
9d74854
Compare
upchuk
force-pushed
the
OPENEUROPA-1414
branch
from
9d74854 to
10a247b
Compare
brummbar
approved these changes
Jan 15, 2019
nagyad
approved these changes
Jan 16, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
OPENEUROPA-1414
Description
When creating a Webtools Analytics rule, we need to add an option that will try to match the default language alias of the current path to the regular expression of the rule.
This PR also contains a lot of cleanup on the module.