Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Currently the provider returns no results #20

Open
LOBsTerr opened this issue Aug 25, 2023 · 2 comments
Open

Currently the provider returns no results #20

LOBsTerr opened this issue Aug 25, 2023 · 2 comments

Comments

@LOBsTerr
Copy link

I have debugged it a bit and I found the problem is here:

        if (empty($content->locations)) {
            return new AddressCollection([]);
        }

Currently no locations are returned from the services, we get:

https://europa.eu/webtools/rest/geocoding/?q=rue+de+la+loi+51+1000+BRUSSELS+BE

{"features":[{"geometry":{"coordinates":[4.3729153,50.8444561],"type":"Point"},"type":"Feature","properties":{"osm_id":"6207518564","country":"Belgi\u00eb - Belgique - Belgien","city":"Ville de Bruxelles - Stad Brussel","countrycode":"BE","postcode":"1000","locality":"Quartier europ\u00e9en - Europese Wijk","type":"house","osm_type":"N","osm_key":"place","housenumber":"51","street":"Rue de la Loi - Wetstraat","district":"Bruxelles \/ Brussel","osm_value":"house","state":"R\u00e9gion de Bruxelles-Capitale - Brussels Hoofdstedelijk Gewest"}}],"type":"FeatureCollection"}

Probably, the format was updated at some point.
in the official page they actually even using address parameter instead of q

https://europa.eu/webtools/rest/geocoding/?address=Rue%20de%20la%20Loi%2056,%20B-1000%20Bruxelles,%20Belgium

LOBsTerr added a commit to LOBsTerr/webtools-geocoding-provider that referenced this issue Aug 28, 2023
@LOBsTerr
Copy link
Author

Since the format has been changes in endpoint we need to adapt the code:

#21

LOBsTerr added a commit to LOBsTerr/webtools-geocoding-provider that referenced this issue Aug 28, 2023
@LOBsTerr
Copy link
Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant