Skip to content

Commit

Permalink
Note on why localrun can't support --watch yet
Browse files Browse the repository at this point in the history
Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
  • Loading branch information
alexellis committed Jun 30, 2023
1 parent 7e7c280 commit 5814824
Showing 1 changed file with 5 additions and 1 deletion.
6 changes: 5 additions & 1 deletion commands/local_run.go
Original file line number Diff line number Diff line change
Expand Up @@ -89,7 +89,11 @@ services deployed within your OpenFaaS cluster.`,
func runLocalRunE(cmd *cobra.Command, args []string) error {

watch, _ := cmd.Flags().GetBool("watch")
fmt.Printf("Watch: %v\n", watch)

// AE: This doesn't work currently due to the blocking nature of
// docker run.
// a channel and / or cancellation context will need to be implemented
// within the watchLoop utility function.
if watch {
return watchLoop(cmd, args, localRunExec)
}
Expand Down

0 comments on commit 5814824

Please sign in to comment.