Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Set Termination Grace Period to write_timeout for functions to allow them to complete during a scale down event. #869

Merged
merged 3 commits into from
Nov 4, 2021

Commits on Nov 3, 2021

  1. Configure pod termination grace period from write_timeout

    Configures the Pod's termination grace period in seconds to
    the write_timeout environment-variable, when available.
    Otherwise, it's set to the default for Kubernetes, which is
    30 seconds.
    
    This change is important for allowing function containers
    to drain active connections, without losing work in
    progress.
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Nov 3, 2021
    Configuration menu
    Copy the full SHA
    1c818f9 View commit details
    Browse the repository at this point in the history

Commits on Nov 4, 2021

  1. Customise makefile

    Allow container registry to be overridden easily for
    local builds
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    eb6ac46 View commit details
    Browse the repository at this point in the history
  2. Add 2s jitter to termination grace period

    The additional 2s should prevent an issue where the grace
    period is exactly the same as the timeout, and kills the Pod
    before the remaining requests have completed.
    
    Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
    alexellis committed Nov 4, 2021
    Configuration menu
    Copy the full SHA
    4e3efd4 View commit details
    Browse the repository at this point in the history