-
Notifications
You must be signed in to change notification settings - Fork 474
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update chart to support IngressClass #930
Conversation
Signed-off-by: Sheng-Kai <wheam2002@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@alexellis i tested this using
$ helm template foo ./chart/openfaas --set ingress.enabled="true" --set ingress.ingressClassName=bar
$ helm template foo ./chart/openfaas --set ingress.enabled="true"
$ helm template foo ./chart/openfaas
they all worked as expected.
@alexellis can you put this into your queue? |
@alexellis @LucasRoesler |
@sqaisar, @alexellis is the only one with merge permissions, but I will bring this up on the Wednesday office hours call openfaas/faas#1683 |
@LucasRoesler Is there any update here? |
@pype-leila unfortunately, i can't do anything, @alexellis is the only one that can merge this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Signed-off-by: Sheng-Kai wheam2002@gmail.com
Description
Motivation and Context
Fixed #895
How Has This Been Tested?
Types of changes
Checklist:
git commit -s