Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update chart to support IngressClass #930

Merged
merged 1 commit into from
Jul 6, 2022
Merged

Conversation

wheam2002
Copy link
Contributor

Signed-off-by: Sheng-Kai wheam2002@gmail.com

Description

Motivation and Context

Fixed #895

  • I have raised an issue to propose this change (required)

How Has This Been Tested?

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist:

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I've read the CONTRIBUTION guide
  • I have signed-off my commits with git commit -s
  • I have added tests to cover my changes.
  • All new and existing tests passed.

Signed-off-by: Sheng-Kai <wheam2002@gmail.com>
Copy link
Member

@LucasRoesler LucasRoesler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@alexellis i tested this using

$ helm template foo ./chart/openfaas  --set ingress.enabled="true" --set ingress.ingressClassName=bar
$ helm template foo ./chart/openfaas   --set ingress.enabled="true"
$ helm template foo ./chart/openfaas  

they all worked as expected.

@LucasRoesler
Copy link
Member

@alexellis can you put this into your queue?

@sqaisar
Copy link

sqaisar commented Jun 21, 2022

@alexellis @LucasRoesler
When this issue will be released?

@LucasRoesler
Copy link
Member

@sqaisar, @alexellis is the only one with merge permissions, but I will bring this up on the Wednesday office hours call openfaas/faas#1683

@pype-leila
Copy link

@LucasRoesler Is there any update here?

@LucasRoesler
Copy link
Member

@pype-leila unfortunately, i can't do anything, @alexellis is the only one that can merge this.

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 031713b into openfaas:master Jul 6, 2022
alexellis added a commit that referenced this pull request Jul 6, 2022
Required for #930 #895

Signed-off-by: Alex Ellis (OpenFaaS Ltd) <alexellis2@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Support ingressClassName when deploying an Ingress
5 participants