Document goleak usage #1249
Merged
Document goleak usage #1249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
**What** - Expand the Contribution guide so to describe using `goleak` in unit tests. This package provides a simple method for detecting goroutine leaks in tests. This will help ensure that we write safe code. Signed-off-by: Lucas Roesler <roesler.lucas@gmail.com>
alexellis
approved these changes
Jul 11, 2019
|
Thanks Lucas, good addition 👍 |
This was referenced Nov 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
goleakin unittests. This package provides a simple method for detecting goroutine
leaks in tests. This will help ensure that we write safe code.
Motivation and Context
design/approvedlabelResolves #1248
How Has This Been Tested?
No tests are required beyond reading the Contribution.md file
Types of changes
Checklist:
git commit -s