-
Notifications
You must be signed in to change notification settings - Fork 57
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Extend faas-store with coherent line drawing functions #91
Conversation
Signed-off-by: esimov <esimovaq@yahoo.com>
What's the example usage please? |
@esimov PTAL |
@esimov I looked at the repo. Please can you add on your repo an example of how someone could construct and example with query string parameters? I know that we know this - but it's not obvious for every OpenFaaS user. We have made some changes to the way that the store works, so you also need to modify Thanks, Alex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please see last comment
@alexellis i have already provided an example with query parameters and it is included into the documentation. Can you check it please? What else i need to modify? |
See my note about functions.json |
Signed-off-by: Endre Simo <esimovaq@yahoo.com>
Signed-off-by: esimov <esimovaq@yahoo.com>
Hi @esimov Please could you check the two build failures after you sent your PR? Just click the links above where you see a red X. Alex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Completed the functions.json
file with the required changes.
Signed-off-by: esimov <esimovaq@yahoo.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Increased timeout limit.
@alexellis can you check it now please? |
From what I saw late on Sunday evening, the image you were using had not been published to the Docker Hub. Glad that @rgee0 put that validation in for us, it's coming in useful Looks like you fixed the error. Alex |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Approved
Thanks for your PR @esimov 👍 |
Yes, that was the problem, that i forgot to publish to the Docker Hub. |
Signed-off-by: esimov esimovaq@yahoo.com
Extended the store with the Coherent Line Drawing function, for which i have opened the following ticket: #90