Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extend faas-store with coherent line drawing functions #91

Merged
merged 4 commits into from
Jul 22, 2019

Conversation

esimov
Copy link
Contributor

@esimov esimov commented Jul 19, 2019

Signed-off-by: esimov esimovaq@yahoo.com

Extended the store with the Coherent Line Drawing function, for which i have opened the following ticket: #90

Signed-off-by: esimov <esimovaq@yahoo.com>
@alexellis
Copy link
Member

What's the example usage please?

@alexellis
Copy link
Member

@esimov PTAL

@alexellis
Copy link
Member

@esimov I looked at the repo. Please can you add on your repo an example of how someone could construct and example with query string parameters?

I know that we know this - but it's not obvious for every OpenFaaS user.

We have made some changes to the way that the store works, so you also need to modify functions.json for this to show up on newer clients.'

Thanks,

Alex

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please see last comment

@esimov
Copy link
Contributor Author

esimov commented Jul 20, 2019

@alexellis i have already provided an example with query parameters and it is included into the documentation. Can you check it please? What else i need to modify?

@alexellis
Copy link
Member

See my note about functions.json

esimov added 2 commits July 21, 2019 22:12
Signed-off-by: Endre Simo <esimovaq@yahoo.com>
Signed-off-by: esimov <esimovaq@yahoo.com>
@alexellis
Copy link
Member

Hi @esimov

Please could you check the two build failures after you sent your PR? Just click the links above where you see a red X.

Alex

Copy link
Contributor Author

@esimov esimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Completed the functions.json file with the required changes.

Signed-off-by: esimov <esimovaq@yahoo.com>
Copy link
Contributor Author

@esimov esimov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Increased timeout limit.

@esimov
Copy link
Contributor Author

esimov commented Jul 22, 2019

@alexellis can you check it now please?

@alexellis
Copy link
Member

From what I saw late on Sunday evening, the image you were using had not been published to the Docker Hub. Glad that @rgee0 put that validation in for us, it's coming in useful

Looks like you fixed the error.

Alex

Copy link
Member

@alexellis alexellis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved

@alexellis alexellis merged commit 0ff9c7a into openfaas:master Jul 22, 2019
@alexellis
Copy link
Member

Thanks for your PR @esimov 👍

@esimov
Copy link
Contributor Author

esimov commented Jul 22, 2019

From what I saw late on Sunday evening, the image you were using had not been published to the Docker Hub. Glad that @rgee0 put that validation in for us, it's coming in useful

Looks like you fixed the error.

Alex

Yes, that was the problem, that i forgot to publish to the Docker Hub.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants