Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: context is not a required field of a RelationshipCondition #120

Merged
merged 2 commits into from
Dec 1, 2023
Merged

fix: context is not a required field of a RelationshipCondition #120

merged 2 commits into from
Dec 1, 2023

Conversation

jon-whit
Copy link
Contributor

@jon-whit jon-whit commented Dec 1, 2023 •
edited
Loading

Description

context is not a required field of a RelationshipCondition. It can be nullable if it is omitted in the TupleKey. We normalize null context to empty context {} automatically.

References

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@jon-whit jon-whit requested a review from a team as a code owner December 1, 2023 19:43
@jon-whit jon-whit merged commit 7ad5c05 into main Dec 1, 2023
6 of 7 checks passed
@jon-whit jon-whit deleted the context-is-not-required branch December 1, 2023 19:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jpadilla jpadilla jpadilla approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jon-whit @jpadilla