Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add batch-check proto definition #203

Merged
merged 18 commits into from
Nov 7, 2024
Merged

feat: add batch-check proto definition #203

merged 18 commits into from
Nov 7, 2024

Conversation

justincoh
Copy link
Contributor

@justincoh justincoh commented Oct 9, 2024 •
edited
Loading

Description

This PR adds the proto definition for the forthcoming batch-check endpoint.

The associated swagger documentation update:
image

References

Overarching batch check RFC is coming soon and will be linked here when it's available.

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

@justincoh justincoh force-pushed the feat/batch-check branch 5 times, most recently from 268cf8c to fe2246f Compare October 10, 2024 18:48
@justincoh justincoh changed the title Feat/batch check feat: add batch-check proto definition Oct 10, 2024
@justincoh justincoh marked this pull request as ready for review October 10, 2024 21:25
@justincoh justincoh requested review from a team as code owners October 10, 2024 21:25
@justincoh justincoh marked this pull request as draft October 14, 2024 20:22
@justincoh justincoh marked this pull request as ready for review October 16, 2024 14:34
@justincoh justincoh requested a review from a team October 16, 2024 14:35
willvedd
willvedd reviewed Nov 1, 2024
View reviewed changes
openfga/v1/openfga_service.proto Outdated Show resolved Hide resolved
openfga/v1/openfga_service.proto Outdated Show resolved Hide resolved
openfga/v1/openfga_service.proto Outdated Show resolved Hide resolved
openfga/v1/openfga_service.proto Outdated Show resolved Hide resolved
@willvedd willvedd mentioned this pull request Nov 7, 2024
Merged
4 tasks
@justincoh justincoh merged commit c14fb4b into main Nov 7, 2024
7 checks passed
@justincoh justincoh deleted the feat/batch-check branch November 7, 2024 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ewanharris ewanharris ewanharris left review comments

@miparnisari miparnisari miparnisari left review comments

@rhamzeh rhamzeh rhamzeh left review comments

@willvedd willvedd willvedd approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@justincoh @rhamzeh @willvedd @miparnisari @ewanharris