Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add name as a filter for ListStores #211

Merged
merged 7 commits into from
Dec 17, 2024

Conversation

kalleep
Copy link
Contributor

@kalleep kalleep commented Nov 14, 2024

Description

While the this rfc is not yet accepted its still useful to implement the ability to filter stores by name for ListStores requests.

References

Part of openfga/rfcs#27

Review Checklist

  • I have clicked on "allow edits by maintainers".
  • I have added documentation for new/changed functionality in this PR or in a PR to openfga.dev [Provide a link to any relevant PRs in the references section above]
  • The correct base branch is being used, if not main
  • I have added tests to validate that the change in functionality is working as expected

If you haven't done so yet, we would appreciate it if you could star the OpenFGA repository. :)

@kalleep kalleep requested review from a team as code owners November 14, 2024 10:46
Copy link

linux-foundation-easycla bot commented Nov 14, 2024

CLA Signed

The committers listed above are authorized under a signed CLA.

@kalleep
Copy link
Contributor Author

kalleep commented Nov 14, 2024

Draft pr for the actual implementation can be found here openfga/openfga#2103

openfga/v1/openfga_service.proto Outdated Show resolved Hide resolved
openfga/v1/openfga_service.proto Show resolved Hide resolved
openfga/v1/openfga_service.proto Outdated Show resolved Hide resolved
jpadilla
jpadilla previously approved these changes Dec 6, 2024
@jpadilla
Copy link
Member

@kalleep we had to fix something else in #214 mind updating again?

@jpadilla jpadilla merged commit 6e048d8 into openfga:main Dec 17, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants