-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: update definitions to support ABAC Conditions #90
Conversation
message ConditionParamTypeRef { | ||
enum TypeName { | ||
TYPE_NAME_UNSPECIFIED = 0; | ||
TYPE_NAME_ANY = 1; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We're keeping any?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If in the future we'll introduce it, it makes sense to have it here so that we reserve the field number
* feat: adding condition for tuple key
openfga/v1/authzmodel.proto
Outdated
min_len: 1, | ||
max_len: 50, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Here and elsewhere in this PR: why do we need this? seems redundant. In the past, we removed these two: see #4
Whenever we have a mix of min_len/max_len and pattern validation, remove the min_len and max_len in favor of an updated pattern that includes the length.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thinking is that the error returned in the case that length isn't within constraints is better value length must be between 1 and 50 runes, inclusive
as opposed to value does not match regex pattern
. It is redundant and likely a slight performance hit, I'll remove for now.
Description
NOTE: this PR targets a new branch
feat/abac
context
context
conditions
context
user
References
Review Checklist
main